Inventory: Separate query_filters for devices and vms #140 #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DouglasHeriot
force-pushed
the
140-separate-vm-device-query
branch
from
d2925dc to
deb5e15
Compare
DouglasHeriot
changed the title
|
@DouglasHeriot Is this ready to review? |
|
Yes this one is ready for review. |
FragmentedPacket
suggested changes
Apr 7, 2020
|
Just an FYI, i'll be cutting a new release pretty soon so if there is anything you want in |
|
@FragmentedPacket how soon? I'll be trying to have this, #153 and a few of those other issues I opened ready in the next day or two. |
|
Would Sunday work for you? |
|
@FragmentedPacket Yeah I can aim to have things ready by Sunday. Thanks. |
I've specifically started with tests for netbox-community#140 new query_filters options and refresh_url
netbox-community#140) Wrote a quite little script to fetch these once-off when this list needs updating. In future, this list could be fetched at runtime by querying the API /api/docs/?format=openapi
DouglasHeriot
force-pushed
the
140-separate-vm-device-query
branch
from
35db7f9 to
fafd265
Compare
…es this for us already (netbox-community#140)
|
@FragmentedPacket This PR is now ready for review. (I'm still working on #155) |
FragmentedPacket
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement separate
device_query_filtersandvm_query_filtersas described in #140 to allow for filtering on parameters specific to devices or vms, and still continue to fetch the other type.Also started on #56 some unit tests for the inventory, specifically to test these changes.