fix(deps): remove unused dependencies #3933
Conversation
lukasholzer
added
the
type: chore
| @@ -7,25 +7,23 @@ | |||
| { | |||
| // Those cannot be upgraded to a major version until we drop support for Node 10 | |||
| packageNames: [ | |||
| 'path-type', | |||
There was a problem hiding this comment.
I sorted these by mistake 👼
There was a problem hiding this comment.
|
I pushed one more patch about mock-require. I'm pretty sure quite a few dependencies can be replaced by a single one. For example, you could use |
|
Can we get this moving please? |
renovate.json5
Outdated
| 'better-opn', | ||
| 'to-readable-stream', | ||
| 'configstore', | ||
| 'http-proxy-middleware', |
There was a problem hiding this comment.
I discovered that this package can be updated since Node.js 10 is no longer supported and doesn't have any other breaking changes.
|
I added one more patch for the docs. It seems it had some peer dependencies specified but are unused? |
renovate.json5
Outdated
| 'http-proxy-middleware', | ||
| 'p-map', | ||
| 'inquirer', |
There was a problem hiding this comment.
Inquirer update should also be possible
renovate.json5
Outdated
| 'better-opn', | ||
| 'to-readable-stream', | ||
| 'chalk', |
There was a problem hiding this comment.
Added chalk to the list since v5.0.0 is ESM only.
|
@erezrokah it seems CI failed, can you restart it please? |
🎉 Thanks for submitting a pull request! 🎉
Summary
I hope tests pass, but these are unused AFAICT.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)