Skip to content

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jan 4, 2022

🎉 Thanks for submitting a pull request! 🎉

Summary

One less direct dependency. It's still used by other dependencies, but hopefully they will be updated eventually too.

Requires #3933


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@erezrokah erezrokah added the type: bug code to address defects in shipped code label Jan 4, 2022
@XhmikosR XhmikosR marked this pull request as ready for review January 6, 2022 13:57
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Jan 6, 2022

@erezrokah maybe land this one too in 8.6.7?

@erezrokah erezrokah enabled auto-merge (squash) January 6, 2022 14:10
@erezrokah erezrokah changed the title chore: replace make-dir package with native fix: replace make-dir package with native Jan 6, 2022
@erezrokah erezrokah added automerge Add to Kodiak auto merge queue and removed automerge Add to Kodiak auto merge queue labels Jan 6, 2022
@erezrokah
Copy link
Contributor

@erezrokah maybe land this one too in 8.6.7?

Going to keep releases small as possible. Helps to figure out regressions

@erezrokah erezrokah merged commit 59f6af7 into netlify:main Jan 6, 2022
@XhmikosR XhmikosR deleted the rm-make-dir branch January 6, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants