This repository was archived by the owner on Oct 10, 2022. It is now read-only.
Improve accessToken logic
#228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
ehmicky
commented
Dec 11, 2020
| "lodash.set": "^4.3.2", | ||
| "micro-api-client": "^3.3.0", | ||
| "node-fetch": "^2.2.0", | ||
| "omit.js": "^2.0.2", |
There was a problem hiding this comment.
This was previously removed by #93
However, omit.js does not use core-js anymore, so we can use it again.
ehmicky
commented
Dec 11, 2020
| } | ||
|
|
||
| get accessToken() { | ||
| return (get(this, 'defaultHeaders.Authorization') || '').replace('Bearer ', '') || null |
There was a problem hiding this comment.
this.defaultHeaders is set by the constuctors, so we can assume it is defined.
ehmicky
commented
Dec 11, 2020
| const { | ||
| defaultHeaders: { Authorization }, | ||
| } = this | ||
| if (typeof Authorization !== 'string' || !Authorization.startsWith('Bearer ')) { |
There was a problem hiding this comment.
This logic is slightly different, but seems to capture the actual intent. @erezrokah What do you think?
There was a problem hiding this comment.
Yes, this looks much better
erezrokah
approved these changes
Dec 13, 2020
erezrokah
force-pushed
the
chore/access-token
branch
from
94ec2c3 to
62d227f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the logic related to
accessToken.