This repository was archived by the owner on Oct 10, 2022. It is now read-only.
Remove omit.js
#93
Merged
Remove omit.js
#93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to netlify/build#1050
This removes the
omit.jsdependency. Besides not being well maintained, it includes an old version ofcore-jswhich prints warning messages onnpm install.We do not want to use
lodash.omitbecause it is huge (1500 lines of code compared to 12 lines of code foromit.js). This is becauselodash.omitcomes with all the extraneous features and utility helpers of the whole Lodash ecosystem. Tiny modules are much simpler to debug and less bug-prone.I could not find any well maintained alternatives on npm except for
filter-obj, which we already use. However it needs to be wrapped with a tiny utility function to make it more convenient.