Fixed weird fullscreen-button size #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korelstar
added a commit
that referenced
this pull request
Apr 24, 2020
* Improved presentation of errors if login (SettingsActivity) or synchronization fails. * Show icon if a note is not synchronized (hint to a possible error) * Refactoring: move common code to new private method getNotesRawQuery(String sql, String[] selectionArgs) New method getLocalModifiedNotes() is a preparation for bugfixing #117 * last part from the previous refactoring * use material design icon and remove old holo icon * Refactoring NoteSQLiteOpenHelper and NoteServerSyncHelper in order to fix several bugs belonging concurrency and synchronization. Outstanding: documentation, testing, cosmetic changes * Show icon if a note is not synchronized (hint to a possible error) * Refactoring: move common code to new private method getNotesRawQuery(String sql, String[] selectionArgs) New method getLocalModifiedNotes() is a preparation for bugfixing #117 * last part from the previous refactoring * use material design icon and remove old holo icon * Refactoring NoteSQLiteOpenHelper and NoteServerSyncHelper in order to fix several bugs belonging concurrency and synchronization. Outstanding: documentation, testing, cosmetic changes * only pull remote changes if this was demanded by the caller * restructure the communication between synchronization task and user interface using callbacks, only try to sync if not offline, otherwise show an error message. * updateNoteAndSync(): only make database changes, if the content really changed (see #104) * javadoc and cleanup * Bugfix for EditNoteActivity: invoke callbacks directly if note wasn't changed in edit (before, callback was never invoked in this case) * Make sure, that saveDataWithUI is not called, when the previous saveAndSync is still running. In addition, start next saveAndSync not before a small delay has passed. * rename auto-sync method; adjust DELAYs * Quick Bugfix: Toast in AsyncTask have to be in onPostExecute * Bugfix: save edited note in offline mode, too * Bugfix: Show error message in UI thread * reduce writes to local storage * reduce logging * Refactor: remove recurrent code * UI enhancement when editing notes (with no changes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a bit of padding to the button, to make it look better:
