-
Notifications
You must be signed in to change notification settings - Fork 138
Render check boxes / checklist / todo [$50 awarded] #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
will not work if you have checkboxes in a ordered or an unordered (or nested) list |
I am not sure if I understand what you mean. As far as I understand, a note is just a text file. What list are you talking about? |
|
Well, is it possible to use Github flavored markdown? |
I would appreciate checkbox support like Google Keep has. You click on the "More" button of a note and then "Show checkboxes" which basically starts a list that has checkboxes as icons. Nextcloud Notes already supports list with
In my opinion you could just ignore cases like that. Nested lists don't work anyway at the moment unless I got the syntax wrong. That's the feature I'm missing most from Google Keep. It was my favorite app for simple lists like shopping lists. |
+1 for this one .... I think this one would be on top of my list :) |
Yes, this would indeed be nice. We could for example render a browser checkbox over the |
Any update on this? Something like in github itself would be nice. I found this one https://blog.github.com/2014-04-28-task-lists-in-all-markdown-documents/ |
No, sorry. That's indeed a nice feature, but nobody had time for implementing, yet. Some help is very appreciated though. On the other hand, it could be advantageous to wait for #204. |
#204 : Pen is a great alternative to simpleMDE (support for image, small popup toolbar if you need it), but it doesn't support checkbox either. |
+1 |
If the Notes app for Nextcloud implements this feature, then a Nextcloud-based Notes app for Android/iOS could used the feature, and awesome functionality would ensue. |
I'd like to take this on. One issue to note, however. The editor (SimpleMDE) doesn't support checkboxes, so I'm seeing several choices:
I'm not sure which one to make 🤷♂️. |
Nice! Please be aware that SimpleMDE isn't maintained anymore and we plan to switch to another editor due to this (see #204). Hence, extending SimpleMDE isn't that helpful. I think we should first switch to another editor and at best, that editor supports checkboxes. But if not, it would be nice if you could extend that editor with check boxes. In the meanwhile, you could help analyzing existing alternative editors. We already collected some in #204, but we still need to test them and compare their functionality. |
Here we go.... no click functionality yet, but a pure CSS solution that works for list items up to two levels! Usage
CSS
Paste it in the inspector-stylesheet to test it out! JSClick functionality works now, but codemirror doesn't see it, so the checkbox doesn't reflect the change, and the changes aren't saved :( I have to look into editing the contents of the codemirror instance programatically....
ANY OF THIS CODE CAN BE USED FOR THE SOLUTION, AND THE BOUNTY WILL BELONG TO THE PERSON/PERSONS WHO IMPLEMENT IT. I RESERVE NO RIGHTS TO THIS CODE. Let's get this one done :) P.S. - This will work in EasyMDE too, if we decide to go with that! EDIT: Formatting and clarification |
Unrelated, but this little bit of CSS increases tabsize to better differentiate list items:
|
Okay, fully working! I'm not familiar with the codebase, and I'm not sure where this code should go, but it will give you fully functioning checkboxes two levels deep... with click functionality! CSS
JS
You can test it out in the JS console right now! Known issuesBugs
Missing
EDIT: Again, this should be compatible with EasyMDE should we choose to use that |
Hello, you aklready did a pretty good work, nice mate ! |
All the features are there now, including mobile support, but I went to fix MORE indentation issues (really gotta figure out what Atom's problem is....) and did them directly through github, so I am not able to sign the commit :( I am at work without access to Git so I'll have to wait until I get home to sign off (unless there's a way to do that through Github)? |
You edited the files directly from GitHub ? |
There was one file that I edited in my last commit, because the indentation was off (don't want to mess up your pretty code!) So yes, I stupidly fixed that directly in Github, and now can't sign off until I get home... Live and learn! Check back in about 5 hours for the signed commit :) |
Fixed by @tnyeanderson in #303, thank you very much! Version 2.6.0 with this functionality is just released to the app store. @tnyeanderson Please feel free to claim the bounty on bountysource |
* Improved presentation of errors if login (SettingsActivity) or synchronization fails. * Show icon if a note is not synchronized (hint to a possible error) * Refactoring: move common code to new private method getNotesRawQuery(String sql, String[] selectionArgs) New method getLocalModifiedNotes() is a preparation for bugfixing #117 * last part from the previous refactoring * use material design icon and remove old holo icon * Refactoring NoteSQLiteOpenHelper and NoteServerSyncHelper in order to fix several bugs belonging concurrency and synchronization. Outstanding: documentation, testing, cosmetic changes * Show icon if a note is not synchronized (hint to a possible error) * Refactoring: move common code to new private method getNotesRawQuery(String sql, String[] selectionArgs) New method getLocalModifiedNotes() is a preparation for bugfixing #117 * last part from the previous refactoring * use material design icon and remove old holo icon * Refactoring NoteSQLiteOpenHelper and NoteServerSyncHelper in order to fix several bugs belonging concurrency and synchronization. Outstanding: documentation, testing, cosmetic changes * only pull remote changes if this was demanded by the caller * restructure the communication between synchronization task and user interface using callbacks, only try to sync if not offline, otherwise show an error message. * updateNoteAndSync(): only make database changes, if the content really changed (see #104) * javadoc and cleanup * Bugfix for EditNoteActivity: invoke callbacks directly if note wasn't changed in edit (before, callback was never invoked in this case) * Make sure, that saveDataWithUI is not called, when the previous saveAndSync is still running. In addition, start next saveAndSync not before a small delay has passed. * rename auto-sync method; adjust DELAYs * Quick Bugfix: Toast in AsyncTask have to be in onPostExecute * Bugfix: save edited note in offline mode, too * Bugfix: Show error message in UI thread * reduce writes to local storage * reduce logging * Refactor: remove recurrent code * UI enhancement when editing notes (with no changes)
Uh oh!
There was an error while loading. Please reload this page.
Hello,
can you copy the feature from google keep to add check boxes?
I could imagen it like this: A note contains at the beginning of there lines:
[ ] Lorem
[x] Ipsum
Then it gets rendered as a checkbox. So notes just needs to parse the first 4 Characters of every line.
The $50 bounty on this issue has been claimed at Bountysource.
The text was updated successfully, but these errors were encountered: