Checkbox functionality

[tnyeanderson]

#117 Adds basic checkbox functionality.

Known bugs:

• Double/Triple checkboxes on some double/triple clicks
• Clicking the very bottom of a checkbox will check the box below it

[tnyeanderson]

Not sure where to start diagnosing the Travis CI build fail... Did I not sign it correctly or something?

[Grotax]

No, the server master branch (which is used in travis) moved to version 17 but the notes apps states that it's compatible with 14 to 16

notes/appinfo/info.xml

Line 25 in 84a4d7f

<nextcloud min-version="14" max-version="16" />

[tnyeanderson]

Should be good to go now :)

[tnyeanderson]

Whoops... Not sure what's wrong with my text editor (Atom), it is doing some weird indentation... It all looked right in Atom before I committed! NOW it should all be fixed :)

[korelstar]

Thank you very much for your contribution! I will review this as soon as possible (I'm currently on a journey).

[tnyeanderson]

Clicking doesn't work on mobile, and I had a bit of a lightbulb moment last night to make the functionality better.... so take time and enjoy your journeys! Give me a day or two and I will see if I can get mobile support and a couple other small improvements before its merged :)

[tnyeanderson]

Should be all set to go now! Maybe in the future we can add an option to hide completed events. Easily done with:

.CodeMirror-line.completed-task {
    display: none;
}

[tnyeanderson]

Oddly enough... it's like it signed itself....... Double check it and merge it in! :)

[korelstar]

No, I manually accepted this check, a few minutes ago. :D

I just tried your code, and I like it very much! Big thank you!

One question: are you done, now? I found only one issue: with Firefox on Android, toggling the checkbox works, but they are not shown as checkboxes - it looks like before your changes. Can you confirm this?

[tnyeanderson]

I am testing in a horrible way (just rsyncing the changed files to my own server to test), but I'm not seeing any issues. I saw similar issues with permissions because of the way I was testing, but once I got the permissions squared away and cleared my cache it loaded fine. Just downloaded Firefox on my LG V30 and not seeing any problems as of now. Sometimes the page would need a few reloads before notes.scss got reprocessed.

In the future, how should I be testing this? Clone the repo into the custom_apps folder and just switch between branches?

Edit: Yes, I should be done now :) thank you for your patience, it's been a while since I last programmed!

[korelstar]

I'm testing in an unprofessional way, too. The best way is to test at least with the latest version and with widespread versions of most important browsers. But since we are doing this in our free time, I think it's okay to do only those tests that are relatively effortless and fix bugs as soon as they are reported.

[GLLM]

Hey @korelstar
I've juste upgraded the app to 2.6.0 but I cannot fin how to use this ?
Can you please advise ?
Thanks

[GLLM]

Got it, you must use hypen + space + [ ] ...

Sorry !

[joelstitch]

I can't seem to get the checkboxes working. I am using Notes 3.2.0 and trying the hypen + space + [ ] ...

but no checkbox, i switch to View mode and still no checkbox.

[korelstar]

@joelstitch Please open a new issue for that with more details, i.e. used browser, exact note's content, screenshot, etc.