RFC: Schematics: Extend from @schematics/angular #882 #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would require a minimum version of the CLI with the devkit dependency correct? |
|
Yes. The extends property got merged into devkit version 0.3.1 which got merged into angular cli 1.7.0-rc.0. |
|
@MichaelWarneke can you add the following peer dependencies to the |
|
Done |
|
Merged into next. Thanks! 👏 👏 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inherit the ngrx schematics from angular schematics.
The angular devkit has been updated to allow extends.
angular/devkit#34
By inheriting the hole package instead of some individual generators reduces boiler plate in the collection.json and makes sure that future angular generators are included automatically.