FIX: Require h5py 2.10 for Windows + Python < 3.6 #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## maint/2.5.x #804 +/- ##
==============================================
+ Coverage 90% 90% +<.01%
==============================================
Files 94 95 +1
Lines 12041 12045 +4
Branches 2142 2142
==============================================
+ Hits 10837 10841 +4
- Misses 856 857 +1
+ Partials 348 347 -1
Continue to review full report at Codecov.
|
effigies
force-pushed
the
enh/h5py_minver
branch
from
e01eec1 to
0d5663f
Compare
effigies
force-pushed
the
enh/h5py_minver
branch
from
0d5663f to
622dfa6
Compare
effigies
force-pushed
the
enh/h5py_minver
branch
2 times, most recently
from
649b007 to
71940fd
Compare
effigies
force-pushed
the
enh/h5py_minver
branch
from
71940fd to
4127cfc
Compare
|
@yarikoptic Care to review? |
|
did only cursory review of the changes - looks good. no changes to setup.* so I shouldn't worry about backports. CI is happy. So no objections/comments from me ;-) |
|
Great! Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Appveyor test fails before version constraint, passes after. Moved logic into a private module that can be dropped along with Python 3.5 support when the time comes without going through a deprecation cycle.
On merge, will port to
masterand rewrite the edge case on Azure. Guess I picked an annoying series to leave on Appveyor.Closes #665.