Skip to content

FIX: Require h5py 2.10 for Windows + Python < 3.6 #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 11, 2019

Conversation

effigies
Copy link
Member

@effigies effigies commented Sep 11, 2019

Forward port of #804 to master.

Starting with the test.


This one is simpler than the commit list makes it look:

commit 69700fe9edeb07cacf014af250e2bdcdb3958bf5 (HEAD -> fix/h5py_minver, origin/fix/h5py_minver)
Merge: 920eefa4 457c8607
Author: Christopher J. Markiewicz <[email protected]>
Date:   Wed Sep 11 10:30:59 2019 -0400

    Merge branch 'maint/2.5.x' into fix/h5py_minver

commit 920eefa4cd421a5d46a041149f457dd71c5e7d86
Author: Christopher J. Markiewicz <[email protected]>
Date:   Wed Sep 11 10:15:19 2019 -0400

    CI: Add expected failing test to Azure

commit 457c860780d43072ddf5268f3a76cb999938949b (upstream/maint/2.5.x, maint/2.5.x)
Merge: 8d68c7f4 4127cfcc
Author: Chris Markiewicz <[email protected]>
Date:   Wed Sep 11 10:03:00 2019 -0400

    Merge pull request #804 from effigies/enh/h5py_minver
    
    FIX: Require h5py 2.10 for Windows + Python < 3.6

Only merge issue was removing appveyor.yml.

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #807 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #807      +/-   ##
=========================================
+ Coverage    90.1%   90.1%   +<.01%     
=========================================
  Files          95      96       +1     
  Lines       11903   11907       +4     
  Branches     2124    2124              
=========================================
+ Hits        10725   10729       +4     
  Misses        833     833              
  Partials      345     345
Impacted Files Coverage Δ
nibabel/_h5py_compat.py 100% <100%> (ø)
nibabel/minc2.py 90% <100%> (-0.13%) ⬇️
nibabel/minc1.py 90.36% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22fe8c2...69700fe. Read the comment docs.

@effigies effigies added this to the 3.0.0 RC1 milestone Sep 11, 2019
@effigies effigies merged commit a9db264 into nipy:master Sep 11, 2019
@effigies effigies deleted the fix/h5py_minver branch September 11, 2019 18:16
@effigies effigies modified the milestones: 3.0.0 RC1, 3.0.0 Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant