TEST: Drop nose for pytest #865

effigies · 2020-01-25T18:21:45Z

This PR exists to make all changes related to #864 easy to view, and makes CI status more visible.

Closes #864.
Replaces #840.

codecov · 2020-01-25T18:24:35Z

Codecov Report

Merging #865 into master will increase coverage by 2.29%.
The diff coverage is 96.82%.

@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
+ Coverage   89.34%   91.63%   +2.29%     
==========================================
  Files          96       96              
  Lines       12378    12062     -316     
  Branches     2184     2173      -11     
==========================================
- Hits        11059    11053       -6     
+ Misses        970      677     -293     
+ Partials      349      332      -17

Impacted Files	Coverage Δ
nibabel/optpkg.py	`97.05% <100%> (+7.31%)`	⬆️
nibabel/testing/helpers.py	`100% <100%> (ø)`
nibabel/__init__.py	`100% <100%> (+6%)`	⬆️
nibabel/testing/__init__.py	`100% <100%> (+1.92%)`	⬆️
nibabel/conftest.py	`100% <100%> (ø)`
nibabel/pydicom_compat.py	`92% <50%> (+28.36%)`	⬆️
nibabel/filebasedimages.py	`84.61% <0%> (-1.2%)`	⬇️
nibabel/dataobj_images.py	`93.1% <0%> (-0.65%)`	⬇️
nibabel/ecat.py	`87.7% <0%> (-0.37%)`	⬇️
nibabel/gifti/gifti.py	`95.08% <0%> (-0.35%)`	⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2a8b52...5657d01. Read the comment docs.

…reason cant run the tests in one pytest command, so added an extra line to travis for now

…helping functions)

…ass check to all of the test methods: couldnt find better way for suppressing tests from abstract classes and allowing for testing from all child classes

effigies

Had a read-through of all of this. Most things look reasonable. I had a few comments mostly on alternative idioms we can try moving to.

.azure-pipelines/windows.yml

nibabel/optpkg.py

nibabel/tests/test_analyze.py

nibabel/tests/test_data.py

effigies · 2020-01-25T21:29:56Z

nibabel/tests/test_deprecator.py

-        assert_equal(func.__doc__, 'foo\n')
+            assert func() == None
+            assert len(w) == 1
+            assert w[0].category is DeprecationWarning


This general form of:

with clear_and_catch_warnings(...) as w: warnings.simplefilter('always') # call assert len(w) == 1 assert w[0].category is DeprecationWarning

can be replaced with:

with pytest.deprecated_call(): assert func() == None

nibabel/tests/test_recoder.py

effigies · 2020-01-29T17:38:45Z

nibabel/tests/test_recoder.py

+    with pytest.raises(AttributeError):
+        rc.__getattribute__('label')
+
+def test_recoder_3():


Doubled up. We might be masking the first one of these...

nibabel/tests/test_scaling.py

nibabel/tests/test_wrapstruct.py

djarecka · 2020-01-29T18:03:38Z

@effigies - thanks for reviewing, I'll address the comments and change the code before Tue

effigies · 2020-01-29T18:06:29Z

@djarecka I just wanted to establish a baseline status. I'm okay with using this as a starting point and divvying up jobs on Tuesday.

Of course, feel free to push on anything you like before then.

TEST: Final nose purge

effigies · 2020-02-20T19:55:19Z

Hi all, this is ready, as far as I'm concerned. There are further things that we can do, but the task of removing the dependency on nose is done, so my inclination is to get it merged, and let any further work be done against master, rather than pytest.

There's a slightly weird issue where the def <func>(): lines aren't getting covered, and that's probably a result of using --pyargs to test the installed version rather than directly testing the source. I'm not sure fiddling with this is a great use of time.

What do y'all think? Anything you see as hold-ups?

effigies · 2020-02-24T13:42:59Z

Okay. I'm doing it. Thanks all for sprinting on this with me!

effigies force-pushed the pytest branch 2 times, most recently from a7eb937 to 2de4052 Compare January 25, 2020 19:40

djarecka and others added 23 commits January 29, 2020 08:57

converting tests with tests/test_a*.py and test_wrapstruct (for some …

5f8d68d

…reason cant run the tests in one pytest command, so added an extra line to travis for now

converting test_b* and test_c*

d65e325

updating travis

5f07260

adding converted test_d*

16187e2

converting more tests to pytest

4ee404b

fixing interaction between fixtures

50de669

moving test_helpers to testing/helpers.py (it contains no tests, but …

def8ceb

…helping functions)

adding new tests to travis

629dc57

adding more tests

51cc6aa

converting more tests

ab2f5dc

converting more tests to pytest

1afb4fd

converting test to pytest, TODO: some tests are failing on osx

152abea

adding pytestmark to test that has not been changed to pytest

2ebef26

fixing test_wrapstruct: removing setUpClass and adding self.header_cl…

d68ba9d

…ass check to all of the test methods: couldnt find better way for suppressing tests from abstract classes and allowing for testing from all child classes

changing travis command after fixes in test_wrapstruct

4f2aa9a

MNT: Separate out pytest and nose jobs

e211a47

TEST: Fix tests broken in the rebase

df6a28e

CI: Add CHECK_TYPE to Azure

bfb63fc

CI: Default to nose for Windows for now

75298a4

RF: Avoid running data script code on doctest

77402be

TEST: Doctests not ready

62132ad

CI: Try alternative CHECK_TYPE test

765bec8

PIN: Avoid pytest 5.3.4 (pytest-dev/pytest#6517)

f908ca4

effigies force-pushed the pytest branch from ba138a0 to f908ca4 Compare January 29, 2020 13:59

effigies commented Jan 29, 2020

View reviewed changes

effigies and others added 11 commits February 10, 2020 21:22

TEST/RF: Reduce redundancy in test_removalschedule, test failure case

f8db80a

Merge remote-tracking branch 'upstream/master' into pytest

d5ef496

changing testing_pytest back to testing

8db1cd9

TEST: Remove last imports of nose

0117212

MNT: Purge nose from requirements, CI

c9d9eba

RF: Remove nose test state code

1c6ea64

RF: Reimplement nibabel.test() and nibabel.bench()

ff922aa

DOC: Replace nose with pytest in the docs

6dc8f0f

DOC: Update benchmark docstrings

0079255

TEST: Final few assert_raises

154b941

Merge remote-tracking branch 'upstream/master' into pytest

9e512bc

effigies mentioned this pull request Feb 19, 2020

TEST: Final nose purge #891

Merged

Merge pull request #891 from effigies/test/final_nose_purge

3a38200

TEST: Final nose purge

effigies changed the title ~~[WIP] TEST: Drop nose for pytest~~ TEST: Drop nose for pytest Feb 19, 2020

effigies added 10 commits February 19, 2020 16:36

Merge remote-tracking branch 'upstream/master' into pytest

b190eeb

FIX: Return pytest.main results from nibabel.test/bench

22d8c65

TEST: Might as well test the testers. Found a bug.

49be50a

CI: Install test requirements through extra dependencies

c049a4e

DOC: Specify current benchmark file

592b310

TEST: Style and parameterization fixes for readability

7392e8f

TEST: Bad test syntax

a7f8e11

TEST/RF: Mock compress_ext_map, instead of fixture

6061651

TEST: Rename tests to ensure running

a98b023

TEST/RF: Reparametrize tests

5657d01

effigies pushed a commit to effigies/nibabel that referenced this pull request Feb 20, 2020

TEST: pytest conversion nipy#864 nipy#865

4cdae21

effigies pushed a commit to effigies/nibabel that referenced this pull request Feb 20, 2020

TEST: test_tractogram to pytest nipy#865 nipy#864

2dfc512

effigies merged commit d9298ed into master Feb 24, 2020

effigies deleted the pytest branch February 24, 2020 13:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TEST: Drop nose for pytest #865

TEST: Drop nose for pytest #865

effigies commented Jan 25, 2020 •

edited

Loading

codecov bot commented Jan 25, 2020 •

edited

Loading

effigies left a comment

effigies Jan 25, 2020

effigies Jan 29, 2020

djarecka commented Jan 29, 2020

effigies commented Jan 29, 2020

effigies commented Feb 20, 2020

effigies commented Feb 24, 2020

TEST: Drop nose for pytest #865

TEST: Drop nose for pytest #865

Conversation

effigies commented Jan 25, 2020 • edited Loading

codecov bot commented Jan 25, 2020 • edited Loading

Codecov Report

effigies left a comment

Choose a reason for hiding this comment

effigies Jan 25, 2020

Choose a reason for hiding this comment

effigies Jan 29, 2020

Choose a reason for hiding this comment

djarecka commented Jan 29, 2020

effigies commented Jan 29, 2020

effigies commented Feb 20, 2020

effigies commented Feb 24, 2020

effigies commented Jan 25, 2020 •

edited

Loading

codecov bot commented Jan 25, 2020 •

edited

Loading