-
Notifications
You must be signed in to change notification settings - Fork 261
TEST: Final nose purge #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## pytest #891 +/- ##
==========================================
- Coverage 91.56% 91.29% -0.27%
==========================================
Files 96 96
Lines 12077 12065 -12
Branches 2175 2173 -2
==========================================
- Hits 11058 11015 -43
- Misses 683 716 +33
+ Partials 336 334 -2
Continue to review full report at Codecov.
|
For minc2.py and volumeutils.py, is there any reason for the decrease of coverage? Maybe some raised exception not catch by pytest. For the rest, LGTM! |
lgtm but just a couple more things:
I was also wondering should we try to remove |
@anibalsolon For coverage losses, I think it's mostly that Codecov is a bit spazzy. There's very often a little +/- that happens with a given PR. We can check #865's coverage report before a final merge to see if there's anything concerning.
|
We missed a couple modules:
This PR also removes the
nosetests
extra and thenosetests
checks from Travis and Azure.With the removal of these tests, we can remove the numpy printoptions code in
nibabel.__init__.py
.Further, the
numpy.testing.NoseTester
is nose-specific, so I rewrotenibabel.test()
andnibabel.bench()
to use Pytest. This can be refactored further in the future if it seems worth it. To make pytest play nicely with benchmarks, I added a config file that will be part of the package.This is best reviewed commit-by-commit.