Skip to content

TEST: Style cleanups, simpler fixtures #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 5, 2020

Conversation

effigies
Copy link
Member

@effigies effigies commented Feb 4, 2020

Hopefully I'm not overlapping with #876, as it looks like @djarecka and I were both going through my backlog of suggestions on #865.

Also fixes the style issue that's going to be making everybody's Travis fail... Sorry.

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #878 into pytest will increase coverage by 0.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           pytest     #878      +/-   ##
==========================================
+ Coverage   82.76%   83.53%   +0.77%     
==========================================
  Files          97       97              
  Lines       12404    12403       -1     
  Branches     2185     2185              
==========================================
+ Hits        10266    10361      +95     
+ Misses       1750     1678      -72     
+ Partials      388      364      -24
Impacted Files Coverage Δ
nibabel/optpkg.py 97.05% <ø> (-0.09%) ⬇️
nibabel/streamlines/tractogram_file.py 100% <0%> (+5%) ⬆️
nibabel/streamlines/trk.py 94.62% <0%> (+16.45%) ⬆️
nibabel/streamlines/tck.py 99.46% <0%> (+19.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 636dc55...92c758a. Read the comment docs.

@effigies effigies merged commit ee4b703 into nipy:pytest Feb 5, 2020
@effigies effigies deleted the test/cleanups2 branch February 20, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant