feat: updated, refactored and cleaned up #180

ovflowd · 2025-07-04T18:36:51Z

This PR removes the usage of very old dependencies for the ones maintained officially by Google with updated APIs.

This PR refactors and modularizes the source code and ensures it is functional via environmnent-based configuration, instead of fie-system ones.

It also amplifies the code, documentation and ensures it is easy to contribute towards.

mhdawson · 2025-07-04T18:39:35Z

I think it would be good to get the updated version working/tested in real life before landing changes to the repo. I won't have time to debug if changes break the live tooling which regularly updates from this repo to pull in changes.

ovflowd · 2025-07-04T18:42:41Z

I think it would be good to get the updated version working/tested in real life before landing changes to the repo. I won't have time to debug if changes break the live tooling which regularly updates from this repo to pull in changes.

+1. I haven't tested this for real yet, so we shouldn't land before I'm able to confirm it works fine. Would unit testing also make sense here?

ovflowd · 2025-07-21T18:35:21Z

Adding HackMD docs as we're closing a partnership with'em.

ovflowd · 2025-07-21T21:48:43Z

cc @avivkeller ☝️

avivkeller · 2025-07-21T22:31:55Z

bin/create-meeting

+console.log(`Running meeting artifacts creation for group: ${group}`);
+
+// Spawn the npm script with proper stdio inheritance
+const child = spawn('npm', ['run', scriptName], {


Wouldn't it make more sense to not rely on npm here? That way, this can be triggered via npx, and not rely on the local package.json containing the scripts (See #179)

Or, explicitly set the cwd to tell npm where the package.json is.

My brain is tired can you make a code suggestion?

Actually, you can delete this whole file and just make create-node-meeting-artifacts.mjs the cli entrypoint.

This file is basically calling create-node-meeting-artifacts.mjs [the input passed]

ovflowd · 2025-08-09T23:01:06Z

FYI this PR staled a bit as I'm going to work next weekend on (Aiming the Sunday or Saturday) (16th/17th of August)

ovflowd · 2025-08-14T22:27:51Z

cc @mhdawson this PR is ready to be reviewed and merged once we set the tokens 🙇

avivkeller · 2025-08-14T22:51:51Z

.github/workflows/create-meeting-artifacts.yml

+          HACKMD_API_TOKEN: ${{ secrets.HACKMD_API_TOKEN }}
+          HACKMD_TEAM_NAME: ${{ secrets.HACKMD_TEAM_NAME }}
+          GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
+        run: node create-node-meeting-artifacts.mjs ${{ github.event.inputs.meeting_group }}


How will this work on schedule? TSC?

You have a schedule trigger on this workflow. When that trigger occurs, ${{ github.event.inputs.meeting_group }} will be blank. Will it default to TSC, like it does here?

No it won't, good question, can I add fields for manual workflow triggers?

Bump, @avivkeller

I don't understand your question. I think if you just remove the schedule trigger, and make this only run manually, it'll be fine

My question is, if we support manual triggers, can we have an input field that allows us to set this? Otherwise I'll remove manual dispatch, as this should be pretty much cron-based.

In the event of a manual trigger, yes, you can define inputs. In the event of a schedule trigger, no, you cannot define inputs.

Why would a schedule trigger even be needed in this repository, shouldn't that be handled by the repos relying on this, not this repo itself?

.github/workflows/test.yml

README.md

package.json

src/constants.mjs

src/github.mjs

src/google.mjs

src/hackmd.mjs

src/config.mjs

src/utils/templates.mjs

ovflowd · 2025-08-19T23:20:18Z

@bensternthal / @ryanaslett I'm ready to set the tokens once openjs-foundation/infrastructure#78 gets done.

avivkeller

The remaining comments of mine are nitpicks.

LGTM, thank you, Claudio!

avivkeller · 2025-08-20T00:21:49Z

package.json

@@ -2,28 +2,79 @@
  "name": "create-node-meeting-artifacts",
  "version": "0.0.1",
  "description": "Creates issue and minutes doc for node meeting",
-  "main": "index.js",
+  "type": "module",
+  "main": "create-node-meeting-artifacts.mjs",
  "bin": {
    "create-meeting": "./bin/create-meeting"


Suggested change

"create-meeting": "./bin/create-meeting"

"create-meeting": "./create-node-meeting-artifacts.mjs"

avivkeller · 2025-08-20T00:24:41Z

package.json

+    "uvwasi-meeting": "node create-node-meeting-artifacts.mjs uvwasi",
+    "uvwasi-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs uvwasi",
+    "tsc-meeting": "node create-node-meeting-artifacts.mjs tsc",
+    "tsc-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs tsc",
+    "build-meeting": "node create-node-meeting-artifacts.mjs build",
+    "build-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs build",
+    "diag-meeting": "node create-node-meeting-artifacts.mjs diag",
+    "diag-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs diag",
+    "diag-deepdive-meeting": "node create-node-meeting-artifacts.mjs diag_deepdive",
+    "diag-deepdive-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs diag_deepdive",
+    "typescript-meeting": "node create-node-meeting-artifacts.mjs typescript",
+    "typescript-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs typescript",
+    "release-meeting": "node create-node-meeting-artifacts.mjs Release",
+    "release-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs Release",
+    "cross-project-council-meeting": "node create-node-meeting-artifacts.mjs cross_project_council",
+    "cross-project-council-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs cross_project_council",
+    "modules-meeting": "node create-node-meeting-artifacts.mjs modules",
+    "modules-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs modules",
+    "tooling-meeting": "node create-node-meeting-artifacts.mjs tooling",
+    "tooling-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs tooling",
+    "security-wg-meeting": "node create-node-meeting-artifacts.mjs security-wg",
+    "security-wg-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs security-wg",
+    "next-10-meeting": "node create-node-meeting-artifacts.mjs next-10",
+    "next-10-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs next-10",
+    "package-maintenance-meeting": "node create-node-meeting-artifacts.mjs package-maintenance",
+    "package-maintenance-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs package-maintenance",
+    "package-metadata-interop-meeting": "node create-node-meeting-artifacts.mjs package_metadata_interop",
+    "package-metadata-interop-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs package_metadata_interop",
+    "ecosystem-report-meeting": "node create-node-meeting-artifacts.mjs ecosystem_report",
+    "ecosystem-report-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs ecosystem_report",
+    "sustainability-collab-meeting": "node create-node-meeting-artifacts.mjs sustainability_collab",
+    "sustainability-collab-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs sustainability_collab",
+    "standards-meeting": "node create-node-meeting-artifacts.mjs standards",
+    "standards-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs standards",
+    "security-collab-meeting": "node create-node-meeting-artifacts.mjs security_collab",
+    "security-collab-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs security_collab",
+    "loaders-meeting": "node create-node-meeting-artifacts.mjs loaders",
+    "loaders-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs loaders",
+    "web-server-frameworks-meeting": "node create-node-meeting-artifacts.mjs web-server-frameworks",
+    "web-server-frameworks-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs web-server-frameworks"


Assuming that https://github.com/nodejs/create-node-meeting-artifacts/pull/180/files#r2286679090 is accepted:

Suggested change

"uvwasi-meeting": "node create-node-meeting-artifacts.mjs uvwasi",

"uvwasi-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs uvwasi",

"tsc-meeting": "node create-node-meeting-artifacts.mjs tsc",

"tsc-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs tsc",

"build-meeting": "node create-node-meeting-artifacts.mjs build",

"build-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs build",

"diag-meeting": "node create-node-meeting-artifacts.mjs diag",

"diag-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs diag",

"diag-deepdive-meeting": "node create-node-meeting-artifacts.mjs diag_deepdive",

"diag-deepdive-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs diag_deepdive",

"typescript-meeting": "node create-node-meeting-artifacts.mjs typescript",

"typescript-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs typescript",

"release-meeting": "node create-node-meeting-artifacts.mjs Release",

"release-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs Release",

"cross-project-council-meeting": "node create-node-meeting-artifacts.mjs cross_project_council",

"cross-project-council-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs cross_project_council",

"modules-meeting": "node create-node-meeting-artifacts.mjs modules",

"modules-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs modules",

"tooling-meeting": "node create-node-meeting-artifacts.mjs tooling",

"tooling-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs tooling",

"security-wg-meeting": "node create-node-meeting-artifacts.mjs security-wg",

"security-wg-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs security-wg",

"next-10-meeting": "node create-node-meeting-artifacts.mjs next-10",

"next-10-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs next-10",

"package-maintenance-meeting": "node create-node-meeting-artifacts.mjs package-maintenance",

"package-maintenance-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs package-maintenance",

"package-metadata-interop-meeting": "node create-node-meeting-artifacts.mjs package_metadata_interop",

"package-metadata-interop-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs package_metadata_interop",

"ecosystem-report-meeting": "node create-node-meeting-artifacts.mjs ecosystem_report",

"ecosystem-report-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs ecosystem_report",

"sustainability-collab-meeting": "node create-node-meeting-artifacts.mjs sustainability_collab",

"sustainability-collab-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs sustainability_collab",

"standards-meeting": "node create-node-meeting-artifacts.mjs standards",

"standards-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs standards",

"security-collab-meeting": "node create-node-meeting-artifacts.mjs security_collab",

"security-collab-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs security_collab",

"loaders-meeting": "node create-node-meeting-artifacts.mjs loaders",

"loaders-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs loaders",

"web-server-frameworks-meeting": "node create-node-meeting-artifacts.mjs web-server-frameworks",

"web-server-frameworks-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs web-server-frameworks"

"uvwasi-meeting": "create-meeting uvwasi",

"uvwasi-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs uvwasi",

"tsc-meeting": "create-meeting tsc",

"tsc-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs tsc",

"build-meeting": "create-meeting build",

"build-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs build",

"diag-meeting": "create-meeting diag",

"diag-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs diag",

"diag-deepdive-meeting": "create-meeting diag_deepdive",

"diag-deepdive-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs diag_deepdive",

"typescript-meeting": "create-meeting typescript",

"typescript-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs typescript",

"release-meeting": "create-meeting Release",

"release-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs Release",

"cross-project-council-meeting": "create-meeting cross_project_council",

"cross-project-council-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs cross_project_council",

"modules-meeting": "create-meeting modules",

"modules-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs modules",

"tooling-meeting": "create-meeting tooling",

"tooling-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs tooling",

"security-wg-meeting": "create-meeting security-wg",

"security-wg-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs security-wg",

"next-10-meeting": "create-meeting next-10",

"next-10-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs next-10",

"package-maintenance-meeting": "create-meeting package-maintenance",

"package-maintenance-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs package-maintenance",

"package-metadata-interop-meeting": "create-meeting package_metadata_interop",

"package-metadata-interop-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs package_metadata_interop",

"ecosystem-report-meeting": "create-meeting ecosystem_report",

"ecosystem-report-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs ecosystem_report",

"sustainability-collab-meeting": "create-meeting sustainability_collab",

"sustainability-collab-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs sustainability_collab",

"standards-meeting": "create-meeting standards",

"standards-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs standards",

"security-collab-meeting": "create-meeting security_collab",

"security-collab-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs security_collab",

"loaders-meeting": "create-meeting loaders",

"loaders-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs loaders",

"web-server-frameworks-meeting": "create-meeting web-server-frameworks",

"web-server-frameworks-meeting:dev": "node --env-file=.env create-node-meeting-artifacts.mjs web-server-frameworks"

feat: updated, refactored and cleaned up

bb43655

avivkeller reviewed Jul 21, 2025

View reviewed changes

feat: updated code/refactored added hackmd integration

3015c48

ovflowd added 2 commits August 15, 2025 00:54

chore: code cleanup and improvements

b84cef0

chore: revert file change

156d5a0

avivkeller reviewed Aug 14, 2025

View reviewed changes

chore: code review

21c8412

ovflowd mentioned this pull request Aug 17, 2025

Creation of Access Token's for Create Meeting Artifacts Bot openjs-foundation/infrastructure#78

Open

3 tasks

avivkeller approved these changes Aug 20, 2025

View reviewed changes

avivkeller reviewed Aug 20, 2025

View reviewed changes

	"create-meeting": "./bin/create-meeting"
	"create-meeting": "./create-node-meeting-artifacts.mjs"

Uh oh!

feat: updated, refactored and cleaned up #180

Are you sure you want to change the base?

feat: updated, refactored and cleaned up #180

Uh oh!

Conversation

ovflowd commented Jul 4, 2025

Uh oh!

mhdawson commented Jul 4, 2025

Uh oh!

ovflowd commented Jul 4, 2025

Uh oh!

ovflowd commented Jul 21, 2025

Uh oh!

ovflowd commented Jul 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ovflowd commented Aug 9, 2025

Uh oh!

ovflowd commented Aug 14, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

avivkeller Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ovflowd commented Aug 19, 2025

Uh oh!

avivkeller left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

avivkeller Aug 20, 2025 •

edited

Loading