-
-
Notifications
You must be signed in to change notification settings - Fork 43
feat: updated, refactored and cleaned up #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ovflowd
wants to merge
5
commits into
nodejs:main
Choose a base branch
from
ovflowd:feat/updated-and-refactored
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bb43655
feat: updated, refactored and cleaned up
ovflowd 3015c48
feat: updated code/refactored added hackmd integration
ovflowd b84cef0
chore: code cleanup and improvements
ovflowd 156d5a0
chore: revert file change
ovflowd 21c8412
chore: code review
ovflowd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# Required: GitHub Token (Needs "repo" permissions) | ||
# GITHUB_TOKEN=your_personal_access_token_or_org_token | ||
|
||
# Required: HackMD Configuration | ||
# HACKMD_API_TOKEN=your_hackmd_api_token | ||
# HACKMD_TEAM_NAME=your_hackmd_team_name_optional # Defaults to your own personal space | ||
|
||
# Google Calendar API Authentication | ||
# You can get this from the Google Cloud Console | ||
# Create an API Key and restrict it to the Google Calendar API | ||
# GOOGLE_API_KEY=your_google_calendar_api_key_here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
name: Create Meeting Artifacts | ||
|
||
on: | ||
# Run every Monday at 10 AM UTC (adjust as needed) | ||
schedule: | ||
- cron: '0 10 * * 1' | ||
|
||
# Allow manual triggering | ||
workflow_dispatch: | ||
inputs: | ||
meeting_group: | ||
description: 'Meeting group to create artifacts for' | ||
required: true | ||
type: choice | ||
options: | ||
- uvwasi | ||
- tsc | ||
- build | ||
- diag | ||
- diag_deepdive | ||
- typescript | ||
- Release | ||
- cross_project_council | ||
- modules | ||
- tooling | ||
- security-wg | ||
- next-10 | ||
- package-maintenance | ||
- package_metadata_interop | ||
- ecosystem_report | ||
- sustainability_collab | ||
- standards | ||
- security_collab | ||
- loaders | ||
- web-server-frameworks | ||
|
||
jobs: | ||
create-artifacts: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 | ||
|
||
- name: Setup Node.js | ||
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3 | ||
with: | ||
node-version-file: '.nvmrc' | ||
cache: 'npm' | ||
|
||
- name: Install dependencies | ||
run: npm ci | ||
|
||
- name: Create meeting artifacts | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
HACKMD_API_TOKEN: ${{ secrets.HACKMD_API_TOKEN }} | ||
HACKMD_TEAM_NAME: ${{ secrets.HACKMD_TEAM_NAME }} | ||
GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }} | ||
run: node create-node-meeting-artifacts.mjs ${{ github.event.inputs.meeting_group }} | ||
|
||
- name: Upload artifacts | ||
if: always() | ||
uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0 | ||
with: | ||
name: meeting-artifacts-${{ github.event.inputs.meeting_group || 'tsc' }} | ||
path: | | ||
~/.make-node-meeting/ | ||
*.md | ||
retention-days: 7 | ||
if-no-files-found: ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
name: Test Suite | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
branches: | ||
- main | ||
|
||
jobs: | ||
test: | ||
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
matrix: | ||
node-version: [22.x, 'latest'] | ||
|
||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 | ||
|
||
- name: Setup Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
cache: 'npm' | ||
|
||
- name: Install dependencies | ||
run: npm ci | ||
|
||
- name: Run linting | ||
run: npm run lint | ||
|
||
- name: Run tests | ||
run: npm test | ||
|
||
- name: Check format | ||
run: npm run format:check | ||
ovflowd marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,15 @@ | ||
# Node.js Packages | ||
node_modules/ | ||
client_secret.json | ||
package-lock.json | ||
|
||
# Environment File | ||
.env | ||
|
||
# Test artifacts and temporary files | ||
test/fixtures/temp/ | ||
test/snapshots/*.snap | ||
*.log | ||
coverage/ | ||
|
||
# Files created during unit test runs | ||
*.sh | ||
meeting-test/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
templates/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"tabWidth": 2, | ||
"useTabs": false, | ||
"semi": true, | ||
"singleQuote": true, | ||
"jsxSingleQuote": false, | ||
"trailingComma": "es5", | ||
"bracketSpacing": true, | ||
"bracketSameLine": false, | ||
"arrowParens": "avoid" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
Michael Dawson <[email protected]> | ||
Claudio Wunder <[email protected]> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will this work on schedule? TSC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a schedule trigger on this workflow. When that trigger occurs,
${{ github.event.inputs.meeting_group }}
will be blank. Will it default to TSC, like it does here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it won't, good question, can I add fields for manual workflow triggers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump, @avivkeller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand your question. I think if you just remove the schedule trigger, and make this only run manually, it'll be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My question is, if we support manual triggers, can we have an input field that allows us to set this? Otherwise I'll remove manual dispatch, as this should be pretty much cron-based.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the event of a manual trigger, yes, you can define inputs. In the event of a schedule trigger, no, you cannot define inputs.
Why would a schedule trigger even be needed in this repository, shouldn't that be handled by the repos relying on this, not this repo itself?