-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Use lts
version instead of version number.
#2953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The guide insists on using the LTS version of Node anyway. This change will spare the documentation maintainers from bumping the version manually each time a new LTS version is released. It also lets avoid inaccuracies with version bumping. An example of such inaccuracy occurred between commit de5f7ef, where the Node version was changed from `carbon` to `8`, and commit b0dd55c, where the version was changed from `8` to `10` only in some places of localized guides.
@nodejs/docker |
I don't think it is usually a good idea to use an alias tag as it can also break as the LTS versions change. Not sure what the current recommendation is from the https://github.com/nodejs/package-maintenance repo since I think they were looking at some recommendations for test matrices On the flip, this text does specifically talk about using LTS |
Otherwise you are left with an untrue statement which indicates an older version of LTS. This is far more confusing and error-prone, as proven in my commit message. The |
I brought this up here: #2293 (comment) I don't have strong opinions one way or the other, although I'm partial to keeping this as-is and adding a checkbox to some release process saying "if this is first LTS release for this major, update nodejs.org". It happens once a year and not too onerous, is it? Of course, it wouldn't be me making that update, so I might be very wrong 🙂 |
The problem with static tags like With all of that said, you could make the argument that for the sake of a tutorial and its maintenance, it's okay to use Maybe a good tradeoff is using |
Would it be possible to change it to |
I believe even the best tutorial will not prevent anyone from misusing software. And you cannot take responsibility for that. I would go with adding a comment stating that in production environment the Node version should most likely be chosen explicitly - for example in cases of legacy projects that somebody decided to encapsulate in a dockerized environment. |
Closing as #2983 bumped it to 12 |
Update node LTS version for the guide for docerizing node applications. Related: nodejs#2983, nodejs#2953
The guide insists on using the LTS version of Node anyway. This change
will spare the documentation maintainers from bumping the version
manually each time a new LTS version is released. It also lets avoid
inaccuracies with version bumping. An example of such inaccuracy
occurred between commit de5f7ef, where the Node version was changed
from
carbon
to8
, and commit b0dd55c, where the version waschanged from
8
to10
only in some places of localized guides.