feat: Initial test case for repl errors #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
reviewed
Jul 28, 2018
test/test-repl-error.js
Outdated
|
|
||
| new REPL(inoutStream, inoutStream); | ||
|
|
||
| const errorMessage = 'SyntaxError: Invalid or unexpected token'; |
There was a problem hiding this comment.
tests shouldn't use specific messages because they change based on which engine node runs in
There was a problem hiding this comment.
hmmm, then how can we assert the expected value?
There was a problem hiding this comment.
take a look at the tests for repl in node core
|
@devsnek Thanks for your help. I have refactored the assertion accordingly. Let me know if anything needs to be done further. |
|
ping @devsnek |
1 similar comment
|
ping @devsnek |
|
i'd like to see if we can set up CI of some sort for the linter before we merge more PRs |
|
@devsnek Perfect! Sounds good to me. |
devsnek
force-pushed
the
master
branch
3 times, most recently
from
371bc3d to
dc3e899
Compare
devsnek
force-pushed
the
master
branch
2 times, most recently
from
2f98d80 to
ef458c1
Compare
|
@devsnek Any update on this? |
devsnek
force-pushed
the
master
branch
2 times, most recently
from
69006e9 to
a8fd2b0
Compare
|
I know it's a long time, any update here? cc @devsnek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @devsnek
I worked on the item : #6
This should be the beginning for adding test cases for repl 👍
Have a look and let me know we can follow the same pattern for other test cases too. Once this is good, may be we can then add scripts to run our tests on our npm build process.
Thanks for your time on this.