This repository was archived by the owner on Nov 16, 2019. It is now read-only.
don't rename *.gyp files #16
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes npm/npm#10243, refs npm/read-package-json#52
Currently,
*.gyp
files are all renamed tobinding.gyp
if apackage.json
file exists in the same directory (potentially clobbering each other if multiple*.gyp
files exist). This can be problematic for packages which use a standalonegyp
build system outside of justnode-gyp
. This patch removes the current behavior and adds a test case to ensure thatmain.gyp
will not be renamed.SEMVER MAJOR
/cc @othiym23