Skip to content
This repository was archived by the owner on Nov 16, 2019. It is now read-only.

don't rename *.gyp files #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

don't rename *.gyp files #16

wants to merge 1 commit into from

Conversation

mikemorris
Copy link

Fixes npm/npm#10243, refs npm/read-package-json#52

Currently, *.gyp files are all renamed to binding.gyp if a package.json file exists in the same directory (potentially clobbering each other if multiple *.gyp files exist). This can be problematic for packages which use a standalone gyp build system outside of just node-gyp. This patch removes the current behavior and adds a test case to ensure that main.gyp will not be renamed.

SEMVER MAJOR

/cc @othiym23

add test case for main.gyp
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant