Skip to content
This repository was archived by the owner on Nov 16, 2019. It is now read-only.

fstream-npm: do not rename *.gyp twice #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

indutny
Copy link

@indutny indutny commented Feb 25, 2016

Do not rename multiple *.gyp files to binding.gyp . As a side-effect, no
.gyp files will be renamed if binding.gyp is present.

Fix: npm/npm#8411

Do not rename multiple *.gyp files to binding.gyp . As a side-effect, no
.gyp files will be renamed if binding.gyp is present.

Fix: npm/npm#8411
@indutny
Copy link
Author

indutny commented Feb 25, 2016

cc @othiym23 I'm not exactly sure if this kind of sort function is acceptable. Other solution may be to set this _renameGyp flag from the sort, if it will see binding.gyp. However, it seems strange too.

Please let me know what you think about it.

@kenany
Copy link
Contributor

kenany commented Feb 26, 2016

Does this accomplish the same thing as #16 does?

@indutny
Copy link
Author

indutny commented Feb 26, 2016

No, @kenany. It is a slightly more compatible solution, IMO. It will still rename .gyp files, but only if there are no binding.gyp, and only the first one of .gyp in any case.

@kenany
Copy link
Contributor

kenany commented Feb 26, 2016

Ah okay :)

@mikemorris
Copy link

Dupe of #16?

@indutny
Copy link
Author

indutny commented Mar 16, 2016

@mikemorris they are different, see #18 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants