fix(#2516): diagnostics icon highlight group matches the documentation: NvimTreeLspDiagnosticsInfo -> Information #2518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n: NvimTreeLspDiagnosticsInfo -> Information
|
Tested OK #2516 (comment) |
Akmadan23
reviewed
Nov 6, 2023
| @@ -72,7 +72,7 @@ function M.setup(opts) | |||
| } | |||
| M.ICON[vim.diagnostic.severity.INFO] = { | |||
| str = M.config.diagnostics.icons.info, | |||
| hl = { "NvimTreeLspDiagnosticsInfo" }, | |||
| hl = { "NvimTreeLspDiagnosticsInformation" }, | |||
There was a problem hiding this comment.
It's a minor gripe, but I would do it the other way around, replacing the others *Information with *Info, since the level is info it would be more intuitive
There was a problem hiding this comment.
Agreed. Info is the consistent option.
I'm just putting this quick fix in for now. I've updated them all to Info in the long running feature branch: https://github.com/nvim-tree/nvim-tree.lua/pull/2455/files#diff-b5b2d1abcb86ead5a2319f7e065a7545b834a407cc9f420590d7acebb285fca9R2283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2516
Proper overhaul incoming: #2415