Skip to content

fix(#2516): diagnostics icon highlight group matches the documentation: NvimTreeLspDiagnosticsInfo -> Information #2518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2023
Merged

fix(#2516): diagnostics icon highlight group matches the documentation: NvimTreeLspDiagnosticsInfo -> Information #2518

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d53aef1
fix(#2516): diagnostics icon highlight group matches the documentatio…
alex-courtis Nov 6, 2023
4750b35
Merge branch 'master' into 2516-DiagnosticsInfo-correction
alex-courtis Nov 12, 2023
4437cbc
Merge branch 'master' into 2516-DiagnosticsInfo-correction
alex-courtis Nov 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lua/nvim-tree/renderer/components/diagnostics.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ function M.setup(opts)
}
M.ICON[vim.diagnostic.severity.INFO] = {
str = M.config.diagnostics.icons.info,
hl = { "NvimTreeLspDiagnosticsInfo" },
hl = { "NvimTreeLspDiagnosticsInformation" },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a minor gripe, but I would do it the other way around, replacing the others *Information with *Info, since the level is info it would be more intuitive

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Info is the consistent option.

I'm just putting this quick fix in for now. I've updated them all to Info in the long running feature branch: https://github.com/nvim-tree/nvim-tree.lua/pull/2455/files#diff-b5b2d1abcb86ead5a2319f7e065a7545b834a407cc9f420590d7acebb285fca9R2283

}
M.ICON[vim.diagnostic.severity.HINT] = {
str = M.config.diagnostics.icons.hint,
Expand Down