test plots #546
Merged
test plots #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Fil
commented
Sep 21, 2021
Fil
commented
- replace proportion plot by "who owns Britain" (& proper attribution)
- adds matrix-diagram which tests textRotate and tickRotate (handle no ticks when rotating #545)
mbostock
reviewed
Sep 23, 2021
mbostock
requested changes
Sep 24, 2021
| }) | ||
| ) | ||
| ], | ||
| caption: "“Who owns Britain?,” by Richard Speigal; data: U.K. Office for National Statistics. Proportion plot by Stephanie Evergreen." |
There was a problem hiding this comment.
Stephanie Evergreen’s blog post on proportion plots is great, and I love that we’re linking to it, but she didn’t create this plot—we did—and she might not want us erroneously attributing it to her. This plot is based on (or if you prefer, a recreation of) the chart Who owns Britain? by Richard Speigal, but we shouldn’t erroneously imply that it was made by him, either, especially since we’ve made a number of stylistic changes.
I think my inclination would be to remove the caption here, and add attribution for Richard Speigal in test/data/README.md alongside Stephanie Evergreen.
Fil
force-pushed
the
fil/who-owns-britain
branch
from
f5d33af to
a5bcf1b
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.