Skip to content

test plots #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2021
Merged

test plots #546

merged 2 commits into from
Nov 29, 2021

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Sep 21, 2021

@Fil Fil requested a review from mbostock September 21, 2021 08:35
})
)
],
caption: "“Who owns Britain?,” by Richard Speigal; data: U.K. Office for National Statistics. Proportion plot by Stephanie Evergreen."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stephanie Evergreen’s blog post on proportion plots is great, and I love that we’re linking to it, but she didn’t create this plot—we did—and she might not want us erroneously attributing it to her. This plot is based on (or if you prefer, a recreation of) the chart Who owns Britain? by Richard Speigal, but we shouldn’t erroneously imply that it was made by him, either, especially since we’ve made a number of stylistic changes.

I think my inclination would be to remove the caption here, and add attribution for Richard Speigal in test/data/README.md alongside Stephanie Evergreen.

@Fil Fil requested a review from mbostock October 28, 2021 14:49
@Fil Fil force-pushed the fil/who-owns-britain branch from f5d33af to a5bcf1b Compare November 29, 2021 14:32
@Fil
Copy link
Contributor Author

Fil commented Nov 29, 2021

rebased

@mbostock mbostock merged commit 7289b58 into main Nov 29, 2021
@mbostock mbostock deleted the fil/who-owns-britain branch November 29, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants