Skip to content

handle no ticks when rotating #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Sep 20, 2021

Fixes #544.

Since I was there, I also took a moment to rewrite the code so to make slightly fewer assumptions about the structure of the axis: namely, rather than only looking at the first element’s attributes, look at each element individually. I don’t seeing this having any immediate practical effect, but it does seem slightly cleaner.

There aren’t any tests for the tickRotate option. Any chance you’d be willing to add some to make sure I haven’t broken anything here, @Fil?

(I tested it in this notebook and it seemed to still work…)

@mbostock mbostock requested a review from Fil September 20, 2021 02:48
@mbostock
Copy link
Member Author

I have to do a release since I just bumped D3 to 7.0.3, so I’m going to land this while I’m at it.

@mbostock mbostock merged commit 63569db into main Sep 20, 2021
@mbostock mbostock deleted the mbostock/fix-empty-tick-rotate branch September 20, 2021 03:19
@Fil Fil mentioned this pull request Sep 21, 2021
@Fil
Copy link
Contributor

Fil commented Sep 21, 2021

looks good! thank you. test added in #546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with no data and nonzero tickRotate
2 participants