handle no ticks when rotating #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have to do a release since I just bumped D3 to 7.0.3, so I’m going to land this while I’m at it. |
Merged
|
looks good! thank you. test added in #546 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #544.
Since I was there, I also took a moment to rewrite the code so to make slightly fewer assumptions about the structure of the axis: namely, rather than only looking at the first element’s attributes, look at each element individually. I don’t seeing this having any immediate practical effect, but it does seem slightly cleaner.
There aren’t any tests for the tickRotate option. Any chance you’d be willing to add some to make sure I haven’t broken anything here, @Fil?
(I tested it in this notebook and it seemed to still work…)