[FIX] Show stderr during build process #49
Conversation
|
You will reintroduce an error. I really think you need to add |
cecton
force-pushed
the
catch-stderr-cto
branch
from
9401ef3 to
19d68f7
Compare
|
@KangOl is that better? |
|
dont like it neither. |
|
@KangOl and now? (^_^) I even make sure the program will not wait for input. DEVNULL here is like Python 3 subprocess' DEVNULL https://docs.python.org/3.4/library/subprocess.html#subprocess.DEVNULL |
According to pull request odoo/odoo#4039 we should log into stderr. But at the end, for the runbot, it's more logical to redirect the logs directly in the log file instead of redirecting streams.
cecton
force-pushed
the
catch-stderr-cto
branch
from
5bc462b to
8858d70
Compare
|
@antonylesuisse to remove all the broken pipe errors from phantomjs (false positive). |
|
I close this pr because it's not needed anymore. I will revert runbot dea8692 since the problem is fixed in odoo odoo/odoo@5a642a8 Odoo can now log into stderr. |
revert commit dea8692 phantomjs stderr is now discarded since odoo commit odoo/odoo@5a642a8 no need to discard odoo stderr from logfile. Close #49
revert commit dea8692 phantomjs stderr is now discarded since odoo commit odoo/odoo@5a642a8 no need to discard odoo stderr from logfile. Close #49
FIX in repor_Catalog
According to pull request odoo/odoo#4039 we
should log into stderr. Therefore, the stderr output of build should be
logged too.