Skip to content

Database Operation Transition: From Badger to Pebble #6523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhangchiqing opened this issue Oct 2, 2024 · 5 comments
Closed

Database Operation Transition: From Badger to Pebble #6523

zhangchiqing opened this issue Oct 2, 2024 · 5 comments
Assignees

Comments

@zhangchiqing
Copy link
Member

Transition the database operation implementation from Badger-based to Pebble-based.

This task is dependent on the refactor that changes from Badger transactions to Badger batch updates.

Copy link
Contributor

github-actions bot commented Jan 1, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Jan 1, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2025
@j1010001 j1010001 reopened this Mar 10, 2025
@j1010001
Copy link
Member

@github-actions github-actions bot removed the Stale Label used when marking an issue stale. label Mar 11, 2025
@zhangchiqing
Copy link
Member Author

For access nodes, once switching storage from badger to pebble, new data will be stored to pebble database, such as transaction, collections, events, transaction results etc. The switch would also make the data query to look up from pebble database. However, this would cause issue if the query is to find the old data previously stored in badger, and return not found by mistake.

To resolve it, we need to build a layer on top of the storage layer, so that once switching to pebble, it can query both badger to pebble for retrieving data. Note, this layer is only needed after the switch, it's not needed before the switch, since all the data are still stored badger.

@fxamacker
Copy link
Member

fxamacker commented Apr 29, 2025

Issue text says:

Transition the database operation implementation from Badger-based to Pebble-based.

I will take a look at the operation layer code and put together a list of any remaining work.

@fxamacker
Copy link
Member

fxamacker commented Apr 29, 2025

Updates #6527 (milestone 2)

This issue was closed with the understanding its scope is limited to #6523 (comment) and these PRs completing that aspect.

When time allows, maybe Leo or I can take a look at the operation layer implementation to see if more work remains in the broader scope of "Transition the database operation implementation from Badger-based to Pebble-based". We can open a separate issue with subtasks if we find any remaining work that was missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants