Skip to content

[Access] Add support for multi-store reading of collections & transactions in Access Nodes #7321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 26, 2025

Conversation

fxamacker
Copy link
Member

@fxamacker fxamacker commented Apr 17, 2025

Updates #6523, #6527, requires #7320

This PR uses multiReader (added in PR #7320) to support reading collections and transactions from both BadgerDB and Pebble.

This is needed after switching from BadgerDB to Pebble without data migration.

@fxamacker fxamacker requested a review from a team April 18, 2025 21:00
Copy link
Member

@zhangchiqing zhangchiqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Faye.

@fxamacker fxamacker requested a review from a team April 23, 2025 22:06
Base automatically changed from fxamacker/add-multi-reader-and-multi-iterator to master April 25, 2025 23:25
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 25.47529% with 196 lines in your changes missing coverage. Please review.

Project coverage is 41.23%. Comparing base (bb094ec) to head (292c23f).

Files with missing lines Patch % Lines
storage/operation/multi_dbstore.go 0.00% 19 Missing ⚠️
cmd/access/node_builder/access_node_builder.go 0.00% 13 Missing ⚠️
storage/store/transaction_result_error_messages.go 40.00% 8 Missing and 4 partials ⚠️
storage/mock/db.go 0.00% 11 Missing ⚠️
storage/store/collections.go 31.25% 9 Missing and 2 partials ⚠️
storage/store/transaction_results.go 26.66% 9 Missing and 2 partials ⚠️
storage/store/chunks_queue.go 40.00% 6 Missing and 3 partials ⚠️
storage/store/light_transaction_results.go 40.00% 6 Missing and 3 partials ⚠️
storage/store/results.go 43.75% 6 Missing and 3 partials ⚠️
storage/store/events.go 20.00% 7 Missing and 1 partial ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7321      +/-   ##
==========================================
- Coverage   41.25%   41.23%   -0.03%     
==========================================
  Files        2196     2197       +1     
  Lines      192164   192358     +194     
==========================================
+ Hits        79280    79310      +30     
- Misses     106266   106403     +137     
- Partials     6618     6645      +27     
Flag Coverage Δ
unittests 41.23% <25.47%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fxamacker fxamacker added this pull request to the merge queue Apr 26, 2025
Merged via the queue into master with commit 3d840dd Apr 26, 2025
57 checks passed
@fxamacker fxamacker deleted the fxamacker/support-multi-db-for-access-node branch April 26, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants