Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

v2.0.0: f08: do not BIND(C) to subroutines with LOGICAL parameters #940

Merged
merged 1 commit into from
Feb 12, 2016

Conversation

jsquyres
Copy link
Member

@jsquyres jsquyres commented Feb 2, 2016

Thanks Paul Romano (@paulromano) for reporting this issue (see open-mpi/ompi#1323).

(cherry picked from commit open-mpi/ompi@704f14f)

@jsquyres already reviewed; @ggouaillardet please sanity check

Thanks Paul Romano for reporting this issue.

(cherry picked from commit 704f14f)
@jsquyres jsquyres added this to the v2.0.0 milestone Feb 2, 2016
@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1302/ for details.

@ggouaillardet
Copy link
Contributor

shall we add open-mpi/ompi#1337 (once you reviewed it) and merge all at once ?
if I understand correctly, it will not break abi (no symbol is removed) and f08 apps will be fixed when recompiled
(well, newly compiled f08 apps will not run with an older f08 openmpI lib, not sure this kind of compatibility matters though)

@jsquyres
Copy link
Member Author

@ggouaillardet I'm ok doing open-mpi/ompi#1337 separately (which I'm [finally] reviewing right now...). Either way, this LOGICAL fix and the default attribute handling functions fix will be separate commits, so I don't see a big deal in making them separate PRs.

@ggouaillardet
Copy link
Contributor

👍

hppritcha added a commit that referenced this pull request Feb 12, 2016
v2.0.0: f08: do not BIND(C) to subroutines with LOGICAL parameters
@hppritcha hppritcha merged commit 6cc6958 into open-mpi:v2.x Feb 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants