Skip to content

mpi_f08: correctly implements MPI_{COMM,TYPE,WIN}_{DUP,NULL_{COPY,DEL… #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2016

Conversation

ggouaillardet
Copy link
Contributor

…ETE}}_FN

Fixes #1323

@ggouaillardet
Copy link
Contributor Author

@jsquyres did you get any chance to review this ?

@jsquyres
Copy link
Member

@ggouaillardet Sorry for the delay.

Looks like you left out MPI_NULL_COPY_FN and MPI_NULL_DELETE_FN. I found this by trying to compile ompi-tests/simple/attr (yes, it's a little suite hidden away in a subdirectory... perhaps it should be moved into the ibm test suite...).

@ggouaillardet
Copy link
Contributor Author

are these really f08 bindings ?

@jsquyres
Copy link
Member

I just checked MPI-3.1, and you're correct -- they were deprecated in MPI-2.0, and therefore not included in the mpi_f08 bindings. Let me go update the test...

@jsquyres
Copy link
Member

👍

jsquyres added a commit that referenced this pull request Feb 11, 2016
mpi_f08: correctly implements MPI_{COMM,TYPE,WIN}_{DUP,NULL_{COPY,DEL…
@jsquyres jsquyres merged commit d98616b into open-mpi:master Feb 11, 2016
@jsquyres
Copy link
Member

@ggouaillardet Can you make v1.10.x and v2.x PRs for this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants