Skip to content

Memory Leak in MPI_Get_elements_x #6291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ax3l opened this issue Jan 21, 2019 · 3 comments
Closed

Memory Leak in MPI_Get_elements_x #6291

ax3l opened this issue Jan 21, 2019 · 3 comments

Comments

@ax3l
Copy link

ax3l commented Jan 21, 2019

Background information

What version of Open MPI are you using? (e.g., v1.10.3, v2.1.0, git branch name and hash, etc.)

master as of 352b667

Describe how Open MPI was installed (e.g., from a source/distribution tarball, from a git clone, from an operating system distribution package, etc.)

From source via spack.

Please describe the system on which you are running

  • Operating system/version: Debian 9
  • Computer hardware: ThinkPad
  • Network type: Local

Details of the problem

The function opal_datatype_compute_ptypes in

ompi/ompi/datatype/ompi_datatype_get_elements.c

Line 52 in 352b667

opal_datatype_compute_ptypes(&datatype->super);
allocates datatypes in

ompi/opal/datatype/opal_datatype_get_count.c

Line 161 in 98afc83

datatype->ptypes = (size_t*)calloc(OPAL_DATATYPE_MAX_SUPPORTED, sizeof(size_t));
that don't seem to be freed.

Seen while running a small MPI-I/O example with HDF5 develop: https://forum.hdfgroup.org/t/hdf5bug-h5fd-mpio-collective-chunking/5279
ggouaillardet added a commit to ggouaillardet/ompi that referenced this issue Jan 22, 2019
@ggouaillardet
opal/datatype: plug a memory leak in opal_datatype_t destructor
7c938f0 
correctly free ptypes if the datatype is not pre-defined.

Thanks Axel Huebl for reporting this.

Refs. open-mpi#6291

Signed-off-by: Gilles Gouaillardet <[email protected]>
@ggouaillardet ggouaillardet mentioned this issue Jan 22, 2019
Merged
@ggouaillardet
Copy link
Contributor

@ax3l thanks for the report !

Meanwhile, feel free to manually download and apply the patch at https://github.com/open-mpi/ompi/pull/6292.patch

karasevb pushed a commit to karasevb/ompi that referenced this issue Jan 30, 2019
@ggouaillardet @karasevb
opal/datatype: plug a memory leak in opal_datatype_t destructor
91ce413 
correctly free ptypes if the datatype is not pre-defined.

Thanks Axel Huebl for reporting this.

Refs. open-mpi#6291

Signed-off-by: Gilles Gouaillardet <[email protected]>
jsquyres pushed a commit to jsquyres/ompi that referenced this issue Jan 30, 2019
@ggouaillardet @jsquyres
opal/datatype: plug a memory leak in opal_datatype_t destructor
90a9c12 
correctly free ptypes if the datatype is not pre-defined.

Thanks Axel Huebl for reporting this.

Refs. open-mpi#6291

Signed-off-by: Gilles Gouaillardet <[email protected]>
(cherry picked from commit 7c938f0)
@jsquyres jsquyres mentioned this issue Jan 30, 2019
Merged
@ggouaillardet
Copy link
Contributor

The fix has landed into both master and v4.0.x branch, so I am now closing this issue.

@ax3l
Copy link
Author

ax3l commented Feb 13, 2019

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ax3l @ggouaillardet