v4.0.x: opal/datatype: plug a memory leak in opal_datatype_t destructor #6336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correctly free ptypes if the datatype is not pre-defined. Thanks Axel Huebl for reporting this. Refs. open-mpi#6291 Signed-off-by: Gilles Gouaillardet <[email protected]> (cherry picked from commit 7c938f0)
edgargabriel
approved these changes
Jan 30, 2019
bosilca
approved these changes
Jan 30, 2019
|
#6348 has to be included (once merged into |
Reset ptypes when cloning a datatype in order to prevent a double free() in the opal_datatype_t destructor. This fixes a bug introduced in open-mpi/ompi@7c938f0 Fixes open-mpi#6346 Signed-off-by: Gilles Gouaillardet <[email protected]> (cherry picked from commit open-mpi/ompi@b395342)
bosilca
approved these changes
Feb 1, 2019
bosilca
pushed a commit
to bosilca/ompi
that referenced
this pull request
Sep 13, 2019
…-destructor-leak v4.0.x: opal/datatype: plug a memory leak in opal_datatype_t destructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correctly free ptypes if the datatype is not pre-defined.
Thanks Axel Huebl for reporting this.
Refs. #6291
Signed-off-by: Gilles Gouaillardet [email protected]
(cherry picked from commit 7c938f0)
@edgargabriel pointed out this master commit to me; I took the liberty of creating a v4.0.x PR for it.