-
Notifications
You must be signed in to change notification settings - Fork 900
Coll/han Improvements on algorithm selection through MCA and configuration file #10828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coll/han Improvements on algorithm selection through MCA and configuration file #10828
Conversation
Can one of the admins verify this patch? |
ok to test |
1 similar comment
ok to test |
bot:ibm:retest |
@FlorentGermain-Bull Would you be able to rebase your branch on |
@FlorentGermain-Bull And be sure to see https://www.mail-archive.com/[email protected]/msg21421.html |
bot:ibm:retest |
ac4fd09
to
62bf950
Compare
FYI it looks like all changes proposed in #10456 are also included here |
bad049f
to
4ae2355
Compare
It worked! Thanks. I've heard that Mellanox is working on Their CI. So no action on your part for that. |
8e52500
to
8b21e0e
Compare
bot:aws:retest |
1 similar comment
bot:aws:retest |
@FlorentGermain-Bull can you rebase this on top of current main if it is still something you want to get in. Thanks |
Allow topological level to be named in configuration file Improve algorithm management and choice Allow algorithm selection (optional) in configuration file Algorithm choice through MCA parameters simplification Signed-off-by: Florent GERMAIN <[email protected]>
8b21e0e
to
9245e27
Compare
@bosilca please review so we can get this into v5. |
@FlorentGermain-Bull Are you planning to bring this back to 5.0.x? |
sorry for the late reply |
Allow topological level to be named in configuration file
Try to read topological level as a string then as an id in configuration file.
Improve algorithm management and choice
Uniformisation of algorithm choice mechanism.
Translation table from name to function pointer is set in ompi/mca/coll/han/coll_han_algos.c as mca_base_var_enum_value_t.
Allow algorithm selection (optional) in configuration file
Algorithm choice can be made directly in the configuration file for han component (see configuration file example).
Algorithm choice through MCA parameters simplification
Algorithm choice is made using their name through an enum.
Configuration file example
Note: Han can only be used on the global_communicator level.
Set of MCA parameters to read a han configuration file: