Coll han update file reading 5.0.x #11043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 5ae5907: Coll/han Improvements:
1a9a3b3: coll/HAN: Don't DQ HAN dynamic @ intra-node subcom...
8805074: Coll han: fix allreduce dynamic calling internal h...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
FlorentGermain-Bull
force-pushed
the
coll_han_update_file_reading_5.0.x
branch
from
5ae5907 to
c24541c
Compare
|
ok to test |
devreal
requested changes
Nov 8, 2022
| /* | ||
| * Stringifier for topological level | ||
| */ | ||
| const char* mca_coll_han_topo_lvl_to_str(TOPO_LVL_T topo_lvl) | ||
| const char* mca_coll_han_topo_lvl_to_str(TOPO_LVL_T topo_lvl_id) |
There was a problem hiding this comment.
I realize t hat this breaks the common naming scheme. It should be ompi_coll_han_topo_lvl_to_str. Given that this has been merged into main already this (and other occurrences) should be fixed in a separate PR.
bosilca
approved these changes
Nov 8, 2022
Signed-off-by: Florent Germain <[email protected]> (cherry picked from commit f242689)
Signed-off-by: George Katevenis <[email protected]> (cherry picked from commit 705f8ec)
Allow topological level to be named in configuration file
Improve algorithm management and choice
Allow algorithm selection (optional) in configuration file
Algorithm choice through MCA parameters simplification
Signed-off-by: Florent GERMAIN <[email protected]>
(cherry picked from commit 9245e27)
Fixes CIDs 1516453, 1516452, and 1516451. Signed-off-by: Joseph Schuchart <[email protected]> (cherry picked from commit 9e558f8)
Signed-off-by: Joseph Schuchart <[email protected]> (cherry picked from commit 3623699)
FlorentGermain-Bull
force-pushed
the
coll_han_update_file_reading_5.0.x
branch
from
c24541c to
425b3eb
Compare
|
bot:ibm:retest |
devreal
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #10828 + #10456 + #10458 + #10983 + #10992 on v5.0.x branch