v5: Fixing missing lock release in mca_pml_ob1_record_htod_event #11220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity CID 1515766 Signed-off-by: David Wootton <[email protected]> (cherry picked from commit 2c5429d)
devreal
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity static analysis reports a missing lock release in mca_pml_ob1_record_htod_event
The error return at line 92 is flagged as missing an unlock of the lock obtained at line 89, which could cause an application hang.
I added the missing lock release.
Signed-off-by: David Wootton [email protected]
(cherry picked from commit 2c5429d)