Skip to content

Find libcuda.so automatically if --with-cuda-lib is not passed. #12382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

nsarka
Copy link

@nsarka nsarka commented Feb 28, 2024

Finding CUDA libraries without having to specify both --with-cuda and --with-cuda-lib was requested in github issue
#12264

Signed-off-by: Nick Sarkauskas [email protected]
(cherry picked from commit cad3d9a)

Finding CUDA libraries without having to specify both --with-cuda and
--with-cuda-lib was requested in github issue
open-mpi#12264

Signed-off-by: Nick Sarkauskas <[email protected]>
(cherry picked from commit cad3d9a)
@github-actions github-actions bot added this to the v5.0.3 milestone Feb 28, 2024
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the docs.

@jsquyres
Copy link
Member

Apologies for not catching this and posting on the original master PR.

@nsarka
Copy link
Author

nsarka commented Feb 29, 2024

Please also update the docs.

I have opened a PR to the main branch here: #12385

…y find libcuda.so

Also, redirect the find output to /dev/null to avoid unnecessary output

Signed-off-by: Nick Sarkauskas <[email protected]>
(cherry picked from commit d57ab5b)
@janjust janjust requested review from jsquyres and janjust March 5, 2024 15:23
@janjust
Copy link
Contributor

janjust commented Mar 5, 2024

@jsquyres done - it has the doc change and the does NOT redirect to a hardcoded path if the user directory does not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants