Update docs to reflect change that configure script will automatically check for libcuda.so #12385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 2007d34: Update docs to reflect change that configure scrip...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
nsarka
force-pushed
the
nsarka/update-docs-to-find-libcuda
branch
from
2007d34 to
983f457
Compare
nsarka
force-pushed
the
nsarka/update-docs-to-find-libcuda
branch
2 times, most recently
from
46b4e88 to
92579a9
Compare
|
I will address them in this PR. Once this is merged I can cherry-pick it to v5.0.x. |
jsquyres
requested changes
Mar 1, 2024
…y find libcuda.so Also, redirect the find output to /dev/null to avoid unnecessary output Signed-off-by: Nick Sarkauskas <[email protected]>
nsarka
force-pushed
the
nsarka/update-docs-to-find-libcuda
branch
from
92579a9 to
d57ab5b
Compare
jsquyres
reviewed
Mar 4, 2024
| @@ -41,14 +41,16 @@ Open MPI offers two flavors of CUDA support: | |||
| shell$ ./configure --prefix=/path/to/ucx-cuda-install --with-cuda=/usr/local/cuda --with-gdrcopy=/usr | |||
|
|
|||
| # Configure Open MPI this way | |||
| shell$ ./configure --with-cuda=/usr/local/cuda --with-cuda-libdir=/usr/local/cuda/lib64/stubs/ --with-ucx=/path/to/ucx-cuda-install <other configure params> | |||
| shell$ ./configure --with-cuda=/usr/local/cuda --with-ucx=/path/to/ucx-cuda-install <other configure params> | |||
There was a problem hiding this comment.
Should this --with-cuda example be something other than /usr/local/cuda (because you'll search that directory by default)?
jsquyres
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for: #12382