ops: add support for user-defined big count ops #13030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devreal
reviewed
Jan 10, 2025
| */ | ||
| if( OPAL_UNLIKELY(full_count > INT_MAX) ) { |
There was a problem hiding this comment.
The cast to int I mentioned on the previous ticket is still problematic (https://github.com/open-mpi/ompi/pull/13030/files#diff-dfd595860dc4d0c9c73114bd8563c0786d063327f6e30955a3e361c3f6098e3dR519). I can file a PR to fix if you prefer handling that separately.
There was a problem hiding this comment.
Will do once this one is in.
There was a problem hiding this comment.
okay moved that assert ahead of the cast.
related to open-mpi#12226 and open-mpi#9194 remove incorrect and misleading comment about ompi_3buff_op_reduce. See open-mpi#967 Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
force-pushed
the
add_support_for_user_defined_bigops
branch
from
5e653ab to
c484f68
Compare
devreal
reviewed
Jan 10, 2025
|
nope, that's part of mega PR #12226 |
|
@bosilca please check when you have a chance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #12226 and #9194
remove incorrect and misleading comment about ompi_3buff_op_reduce. See #967