op: allow user operations in ompi_3buff_op_reduce #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows user operations to be used in the ompi_3buff_op_reduce function. This fixes an issue identified in: http://www.open-mpi.org/community/lists/devel/2014/04/14586.php and http://www.open-mpi.org/community/lists/users/2015/10/27769.php The fix is to copy source1 into the target then call the user op function with source2 and target. Fixes open-mpi#966 Signed-off-by: Nathan Hjelm <[email protected]>
|
@bosilca Please take a look. |
|
@bosilca I am going to go ahead and commit this to master. I will assign you to the 1.10.1 PR. I ran the user reproducer and it runs fine with this commit. |
hjelmn
added a commit
that referenced
this pull request
Oct 3, 2015
op: allow user operations in ompi_3buff_op_reduce
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Aug 23, 2016
opal/memory: Move Memory Allocation Hooks usage from openib
hppritcha
added a commit
to hppritcha/ompi
that referenced
this pull request
Jan 9, 2025
related to open-mpi#12226 and open-mpi#9194 remove incorrect and misleading comment about ompi_3buff_op_reduce. See open-mpi#967 Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
added a commit
to hppritcha/ompi
that referenced
this pull request
Jan 10, 2025
related to open-mpi#12226 and open-mpi#9194 remove incorrect and misleading comment about ompi_3buff_op_reduce. See open-mpi#967 Signed-off-by: Howard Pritchard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows user operations to be used in the
ompi_3buff_op_reduce function. This fixes an issue identified in:
http://www.open-mpi.org/community/lists/devel/2014/04/14586.php
and
http://www.open-mpi.org/community/lists/users/2015/10/27769.php
The fix is to copy source1 into the target then call the user op
function with source2 and target.
Fixes #966
Signed-off-by: Nathan Hjelm [email protected]