Skip to content

v2.x: opal: add support for s390 and s390x architectures #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2017

Conversation

nmorey
Copy link
Contributor

@nmorey nmorey commented May 5, 2017

Signed-off-by: Nicolas Morey-Chaisemartin [email protected]

Signed-off-by: Nicolas Morey-Chaisemartin <[email protected]>
@ompiteam-bot
Copy link

Can one of the admins verify this patch?

@jsquyres
Copy link
Member

jsquyres commented May 5, 2017

@nmorey The intent for this PR is to enable Vader's CMA support to compile on S390[X] platforms, is that correct? Note that we usually commit such fixes to master first, and then cherry-pick them to the relevant release branches. Can you open a corresponding PR against master?

@bosilca @hjelmn Can you have a quick look? Looks fairly straightforward.

@jsquyres jsquyres requested review from hjelmn and bosilca May 5, 2017 10:51
@jsquyres
Copy link
Member

jsquyres commented May 5, 2017

Cross-reference: #3443

@nmorey
Copy link
Contributor Author

nmorey commented May 5, 2017

@jsquyres Yes. I had to fix 2.1.0 build for SUSE so I sent the patch as is but I can probably port it to master.

@jsquyres
Copy link
Member

jsquyres commented May 5, 2017

@nmorey Excellent; thanks!

@jsquyres jsquyres changed the title opal: add support for s390 and s390x architectures v2.x: opal: add support for s390 and s390x architectures May 5, 2017
@bwbarrett
Copy link
Member

@jsquyres, we shouldn't merge this patch to 2.x until it's 1) in master and 2) there's a PR to 3.x as well...

@nmorey
Copy link
Contributor Author

nmorey commented May 5, 2017

@bwbarrett I'll do one for 3.x once master gets accepted then :)

@bwbarrett
Copy link
Member

@nmorey: yes, the usual path for PRs in Open MPI is master then to the branches. @jsquyres, @hppritcha, and I are currently trying to make sure that we don't accidentally ship something in 2.1, but then not in 3.0, so the comment was as much for us as anyone :).

@jsquyres
Copy link
Member

jsquyres commented May 6, 2017

#3454 was just merged to master; it is a slightly updated version of this PR (i.e., added a comment).

@jsquyres jsquyres added this to the v2.1.1 milestone May 6, 2017
@jsquyres
Copy link
Member

jsquyres commented May 6, 2017

@hppritcha Do you have an opinion on whether this should go to v2.1.1 or v2.1.2?

@jsquyres
Copy link
Member

jsquyres commented May 8, 2017

Corresponding master PR: #3454

@jsquyres
Copy link
Member

jsquyres commented May 8, 2017

Per discussion with @bwbarrett, this will go into v3.x, so let's go ahead and take this in v2.x.

@jsquyres jsquyres merged commit dbf044a into open-mpi:v2.x May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants