master: opal: add support for s390 and s390x architectures #3454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
jsquyres
changed the title
|
From what I see in the code there is no practical difference between s390 and s390x from OMPI perspective. I wonder why are we creating 2 defines? |
|
It is not completely necessary now but as they are 31 and 64 bit arch, I anticipated some differences that may appear later |
bosilca
approved these changes
May 5, 2017
nmorey
force-pushed
the
devel/master-s390-support
branch
from
7976eec to
7bad4fd
Compare
Signed-off-by: Nicolas Morey-Chaisemartin <[email protected]>
nmorey
force-pushed
the
devel/master-s390-support
branch
from
7bad4fd to
b4d9d5e
Compare
|
Thanks @nmorey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nicolas Morey-Chaisemartin [email protected]