Fix --without-lsf and LSF in default search path #4204
Conversation
* Spaces not tabs, and indent properly * No functional changes here Signed-off-by: Joshua Hursey <[email protected]>
* Will display a message acknowledging the configure setting instead of 'simple ok' which is misleading. Signed-off-by: Joshua Hursey <[email protected]>
…ach path * Reference Issue open-mpi#3546 * If the user specified `--without-lsf` then do not check for it on the system, even if it is there. This can lead to the build failure identified in the issue above. Signed-off-by: Joshua Hursey <[email protected]>
|
To all that review this:
|
| AC_MSG_ERROR([Cannot continue])], | ||
| [AC_MSG_RESULT([sanity check ok ($2)])] | ||
| [AS_IF([test "x`ls $2/$3 2> /dev/null`" = "x"], |
There was a problem hiding this comment.
would test ! -e "$2/$3" do the trick here ?
There was a problem hiding this comment.
Possibly. I didn't want to change the prior behavior, so I left it as is. The git diff shows the indentation change in an odd way :/
There was a problem hiding this comment.
Can't remember why we initially went with ls instead of test -e. Seems like a (slightly) odd choice, but ls works just fine.
|
@jjhursey Do we need to bring the change to opal_check_withdir over to PMIx? |
|
@rhc54 yeah we will. It's somewhat cosmetic, but does help clarify when looking at a snippet of configure output. I can do that once I merge this PR in and post the PRs to the various release branches - later this evening. |
OPAL_CHECK_WITHDIR