Fix --without-lsf and LSF in default search path #4227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jjhursey
commented
Sep 18, 2017
jjhursey
commented
- See PR Fix --without-lsf and LSF in default search path #4204
- See Issue './configure --without-lsf' causes build to fail with "no/lib" error #3546
* Spaces not tabs, and indent properly * No functional changes here Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit 39a83a2) Signed-off-by: Joshua Hursey <[email protected]>
* Will display a message acknowledging the configure setting instead of 'simple ok' which is misleading. Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit fe97d3e) Signed-off-by: Joshua Hursey <[email protected]>
…ach path * Reference Issue open-mpi#3546 * If the user specified `--without-lsf` then do not check for it on the system, even if it is there. This can lead to the build failure identified in the issue above. Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit 24a8b5c) Signed-off-by: Joshua Hursey <[email protected]>
ggouaillardet
approved these changes
Sep 19, 2017
|
@jjhursey could you add something to the NEWS for this PR? |
Signed-off-by: Joshua Hursey <[email protected]>
|
@hppritcha I just pushed a new commit that adds a note to |
|
@jsquyres I think good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.