btl/base_am_rdma: fix handling of btl_send returning 1 #9695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwbarrett
requested changes
Nov 23, 2021
wzamazon
force-pushed
the
btl_am_rdma_handle_btl_send_return_1
branch
from
c4b7b1b to
92bba55
Compare
bwbarrett
requested changes
Nov 24, 2021
Active message RDMA uses btl_send to send the initial request and RDMA response. btl_send will return 0 when the descriptor has been successfully queued for send, and will return 1 when the desciptor has been successfully sent. Currently, active message RDMA treats the return value 1 as an error, thus will either return the value to caller, or retry the send. This patch address the issue by correctly handling the return value 1. Signed-off-by: Wei Zhang <[email protected]>
wzamazon
force-pushed
the
btl_am_rdma_handle_btl_send_return_1
branch
from
92bba55 to
7b177ce
Compare
bwbarrett
approved these changes
Nov 24, 2021
|
The PR build checker failed because a git issue: should not be related to the PR. |
|
bot:aws:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active message RDMA uses btl_send to send the initial
request and RDMA response.
btl_send will return 0 when the descriptor has been
successfully queued for send, and will return 1 when
the desciptor has been successfully sent.
Currently, active message RDMA treats the return value
1 as an error, thus will either return the value
to caller, or retry the send.
This patch address the issue by correctly handling
the return value 1.
Signed-off-by: Wei Zhang [email protected]