v5.0.x: btl: introduce flag MCA_BTL_FLAGS_RDMA_REMOTE_COMPLETION #9938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduced a new flag MCA_BTL_FLAGS_RDMA_REMOTE_COMPLETION, which is used to indicate whether a btl's RDMA/atomic operations support remote completion. btl/self, btl/ofi and btl/ugni support remote completion, thus this patch added the flags to them. Active message RDMA/atomic supports remote completion under certain condition, this patch implemented that logic. Signed-off-by: Wei Zhang <[email protected]> (cherry picked from commit 8f4cda3)
wzamazon
approved these changes
Jan 28, 2022
Active message RDMA uses btl_send to send the initial request and RDMA response. btl_send will return 0 when the descriptor has been successfully queued for send, and will return 1 when the desciptor has been successfully sent. Currently, active message RDMA treats the return value 1 as an error, thus will either return the value to caller, or retry the send. This patch address the issue by correctly handling the return value 1. Signed-off-by: Wei Zhang <[email protected]> (cherry picked from commit 7b177ce)
Static analysis found a few typos in 7b177ce: "&&" should have been "&". Fixes CIDs 1494439 and 1494440. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 5ca231c)
|
@wzamazon thanks ! I pushed them to this PR. |
janjust
approved these changes
Jan 28, 2022
bwbarrett
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduced a new flag MCA_BTL_FLAGS_RDMA_REMOTE_COMPLETION,
which is used to indicate whether a btl's RDMA/atomic operations support
remote completion.
btl/self, btl/ofi and btl/ugni support remote completion, thus this patch
added the flags to them.
Active message RDMA/atomic supports remote completion under certain
condition, this patch implemented that logic.
Signed-off-by: Wei Zhang [email protected]
(cherry picked from commit 8f4cda3)