Skip to content

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Oct 19, 2020

both my PRs #334 and #335 failed because of a new eslint rule. I thought you might want to merge this in first in case the PRs get blocked. I added the same commit to the PRs to get them to green

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #336 into master will increase coverage by 2.53%.
The diff coverage is 88.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   86.40%   88.93%   +2.53%     
==========================================
  Files           5        5              
  Lines         250      226      -24     
  Branches       88       77      -11     
==========================================
- Hits          216      201      -15     
+ Misses         22       18       -4     
+ Partials       12        7       -5     
Impacted Files Coverage Δ
src/index.ts 81.81% <60.00%> (-4.55%) ⬇️
src/v2.ts 83.72% <81.57%> (-2.95%) ⬇️
src/v3.ts 90.72% <90.32%> (+22.42%) ⬆️
src/utils.ts 95.55% <94.11%> (-1.89%) ⬇️
src/property-mapper.ts 84.21% <100.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 624b66c...93ad654. Read the comment docs.

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I have been on-the-fence about the strictness of the ESLint rules. I do feel that they can help beginners as they encourage good habits (and beginners are what I want to optimize for). But also, no one has fun debugging ESLint. Either way, thanks for making this change, and happy for feedback on the ESLint rules in general.

@drwpow drwpow merged commit eaa228a into openapi-ts:master Oct 20, 2020
@gr2m
Copy link
Contributor Author

gr2m commented Oct 20, 2020

I just use prettier for formatting these days. I really like the setup in snowpack, where an action just fixes formatting after merging, it's not even part of the CI because it doesn't have to. And when using TypeScript, many errors that eslint would catch are caught by tsc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants