Skip to content

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Oct 20, 2020

This PR combines the other separate PRs I opened. If you want to merge them all, merging this one is the easiest way, as there are some merge conflicts

closes #337
closes #339

fixes #329
fixes #338

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #340 into master will increase coverage by 5.40%.
The diff coverage is 92.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
+ Coverage   86.40%   91.80%   +5.40%     
==========================================
  Files           5        5              
  Lines         250      244       -6     
  Branches       88       84       -4     
==========================================
+ Hits          216      224       +8     
+ Misses         22       14       -8     
+ Partials       12        6       -6     
Impacted Files Coverage Δ
src/index.ts 81.81% <60.00%> (-4.55%) ⬇️
src/v2.ts 83.72% <81.57%> (-2.95%) ⬇️
src/v3.ts 94.78% <94.59%> (+26.48%) ⬆️
src/property-mapper.ts 84.21% <100.00%> (+5.26%) ⬆️
src/utils.ts 100.00% <100.00%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaa228a...16d9d44. Read the comment docs.

gr2m added a commit to octokit/openapi-types.ts that referenced this pull request Oct 20, 2020
Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approved the other ones; happy to merge this one or the others. Your pick! (also, sorry—I probably should have started with this one!)

@gr2m
Copy link
Contributor Author

gr2m commented Oct 23, 2020

no worries, I should have warned you :D I'll probably resolve the conflicts and address #337 (comment) in this PR, so I don't have to resolve the conflicts twice for #337 and #339

@gr2m gr2m changed the title feat: requestBody, $ref-type parameters, empty response types feat: requestBody, $ref-type parameters Oct 23, 2020
@gr2m
Copy link
Contributor Author

gr2m commented Oct 23, 2020

ready for you @drwpow

@gr2m gr2m mentioned this pull request Oct 23, 2020
@drwpow drwpow merged commit 1f65d8d into openapi-ts:master Oct 23, 2020
@gr2m
Copy link
Contributor Author

gr2m commented Oct 23, 2020

oh how exciting, thank you!! Could you release a new version? I'd be also happy to help you setup semantic-release for continuous releases via GitHub Actions, so you will never see a question like this again lol

@gr2m gr2m deleted the gr2m-goodies branch October 23, 2020 23:00
@drwpow
Copy link
Contributor

drwpow commented Oct 23, 2020

Of course! I can release a new minor version with these awesome new features.

Re: semantic-release, I’m pretty neutral on it. Autoreleases are awesome, but in your experience has it been difficult trying to get commit messages to be formatted properly? Happy to do whatever is less work overall.

@gr2m
Copy link
Contributor Author

gr2m commented Oct 23, 2020

I'm not really impartial because I'm one of the maintainers of semantic-release :D There are really only 3 conventions that matter, I would document them in CONTRIBUTING.md, such as https://github.com/octokit/rest.js/blob/master/CONTRIBUTING.md#merging-the-pull-request--releasing-a-new-version

The biggest boo boo that I've seen happening is when someone had a typo in BREAKING CHANGE: and semantic-release published a fix/feature release instead of a breaking one. But that's fixed easy enough, I'd be here to help with all your semantic-release questions anyway.

But I do say this: I would never be able to maintain as many npm packages as I do without semantic-release. No way.

@drwpow
Copy link
Contributor

drwpow commented Oct 23, 2020

OK you’ve sold me! 🙂 I’ll try adding it myself, and ping you if I have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requestBody parameters are missing Support $ref-type parameters, as well as components.parameters
2 participants