-
-
Notifications
You must be signed in to change notification settings - Fork 582
feat: requestBody
, $ref
-type parameters
#340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
==========================================
+ Coverage 86.40% 91.80% +5.40%
==========================================
Files 5 5
Lines 250 244 -6
Branches 88 84 -4
==========================================
+ Hits 216 224 +8
+ Misses 22 14 -8
+ Partials 12 6 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already approved the other ones; happy to merge this one or the others. Your pick! (also, sorry—I probably should have started with this one!)
no worries, I should have warned you :D I'll probably resolve the conflicts and address #337 (comment) in this PR, so I don't have to resolve the conflicts twice for #337 and #339 |
requestBody
, $ref
-type parameters, empty response types requestBody
, $ref
-type parameters
ready for you @drwpow |
oh how exciting, thank you!! Could you release a new version? I'd be also happy to help you setup semantic-release for continuous releases via GitHub Actions, so you will never see a question like this again lol |
Of course! I can release a new minor version with these awesome new features. Re: semantic-release, I’m pretty neutral on it. Autoreleases are awesome, but in your experience has it been difficult trying to get commit messages to be formatted properly? Happy to do whatever is less work overall. |
I'm not really impartial because I'm one of the maintainers of The biggest boo boo that I've seen happening is when someone had a typo in But I do say this: I would never be able to maintain as many npm packages as I do without semantic-release. No way. |
OK you’ve sold me! 🙂 I’ll try adding it myself, and ping you if I have any questions. |
This PR combines the other separate PRs I opened. If you want to merge them all, merging this one is the easiest way, as there are some merge conflicts
closes #337
closes #339
fixes #329
fixes #338