feat: $ref-type parameters
#337
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 86.40% 90.71% +4.31%
==========================================
Files 5 5
Lines 250 237 -13
Branches 88 81 -7
==========================================
- Hits 216 215 -1
+ Misses 22 16 -6
+ Partials 12 6 -6
Continue to review full report at Codecov.
|
6 tasks
drwpow
reviewed
Oct 23, 2020
| if (p.name) { | ||
| allParameters[p.in][p.name] = p; | ||
| if ("$ref" in p) { | ||
| // return; |
drwpow
reviewed
Oct 23, 2020
| query: { | ||
| per_page: components["parameters"]["per_page"]; | ||
| page: components["parameters"]["page"]; | ||
| since: components["parameters"]["since"]; |
drwpow
reviewed
Oct 23, 2020
| ); | ||
| }); | ||
|
|
||
| it("$ref-type parameters (#329)", () => { |
drwpow
approved these changes
Oct 23, 2020
drwpow
referenced
this pull request
Oct 23, 2020
* test: `$ref`-type parameters * feat: `$ref`-type parameters * test: `requestBody` types * feat: `requestBody` types * refactor: remove obsolete line of code addresses https://github.com/drwpow/openapi-typescript/pull/337\#discussion_r511181303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #329