Skip to content

feat: requestBody types #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

feat: requestBody types #339

wants to merge 3 commits into from

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Oct 20, 2020

fixes #338

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #339 into master will increase coverage by 2.77%.
The diff coverage is 88.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
+ Coverage   86.40%   89.17%   +2.77%     
==========================================
  Files           5        5              
  Lines         250      231      -19     
  Branches       88       78      -10     
==========================================
- Hits          216      206      -10     
+ Misses         22       18       -4     
+ Partials       12        7       -5     
Impacted Files Coverage Δ
src/index.ts 81.81% <60.00%> (-4.55%) ⬇️
src/v2.ts 83.72% <81.57%> (-2.95%) ⬇️
src/v3.ts 91.17% <90.81%> (+22.88%) ⬆️
src/utils.ts 95.55% <94.11%> (-1.89%) ⬇️
src/property-mapper.ts 84.21% <100.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 624b66c...2802c89. Read the comment docs.

@@ -194,6 +226,9 @@ export interface paths {
}
'/store/order': {
post: {
requestBody: {
'*/*': components['schemas']['Order']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah interesting. Didn’t even know you could do this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not exactly sure if this is part of the specification, but GitHub is using it for its "Upload a release asset" endpoint, which allows you to upload any kind of file, of any type

}

export interface components {}
`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 You’re on fire! 😄

@drwpow drwpow closed this in #340 Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requestBody parameters are missing
2 participants