Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Remove convert_to_numpy attribute from DataSource #259

Closed
JackKelly opened this issue Oct 22, 2021 · 2 comments · Fixed by #265
Closed

Remove convert_to_numpy attribute from DataSource #259

JackKelly opened this issue Oct 22, 2021 · 2 comments · Fixed by #265
Assignees
@JackKelly
Labels
enhancement New feature or request good first issue Good for newcomers refactoring

Comments

@JackKelly
Copy link
Member

Detailed Description

I think convert_to_numpy is no longer needed?
@JackKelly JackKelly added enhancement New feature or request refactoring labels Oct 22, 2021
@peterdudfield
Copy link
Contributor

I dont think so, comment it out, run tests, see what happens?

Probably links with #170

@peterdudfield peterdudfield added the good first issue Good for newcomers label Oct 22, 2021
@JackKelly JackKelly self-assigned this Oct 22, 2021
@JackKelly
Copy link
Member Author

Cool, I'll look into this now 🙂

JackKelly added a commit that referenced this issue Oct 22, 2021
@JackKelly
Remove convert-to-numpy. #259
585c693
@JackKelly JackKelly mentioned this issue Oct 22, 2021
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JackKelly JackKelly

Labels
enhancement New feature or request good first issue Good for newcomers refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove convert_to_numpy openclimatefix/nowcasting_dataset
2 participants
@JackKelly @peterdudfield