Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Remove convert_to_numpy #265

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Remove convert_to_numpy #265

merged 1 commit into from
Oct 22, 2021

Conversation

JackKelly
Copy link
Member

Pull Request

Description

The code no longer uses convert_to_numpy. This PR removes all mention of convert_to_numpy. I searched through the code using grep -r --include=*.py "convert_to_numpy" and removed every single mention of convert_to_numpy!

Fixes #259

How Has This Been Tested?

The tests pass.

  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@JackKelly JackKelly added enhancement New feature or request refactoring labels Oct 22, 2021
@JackKelly JackKelly self-assigned this Oct 22, 2021
@JackKelly JackKelly merged commit a14ee21 into main Oct 22, 2021
@JackKelly JackKelly deleted the jack/remove-convert-to-numpy branch October 22, 2021 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request refactoring
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove convert_to_numpy attribute from DataSource
2 participants